Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAC] integrating rbac search strategy with alert flyout #107748

Merged
merged 6 commits into from
Aug 12, 2021
Merged

[RAC] integrating rbac search strategy with alert flyout #107748

merged 6 commits into from
Aug 12, 2021

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Aug 5, 2021 •
edited
Loading

Summary

We are integrating alert search strategy with RBAC on top of alert flyout for security solution.

Steps to verify:

  1. Please check if the data in these flyouts loaded properly:

Screenshot 2021-08-12 at 09 35 39

Screenshot 2021-08-12 at 09 34 55

Screenshot 2021-08-12 at 09 34 31

Screenshot 2021-08-12 at 09 34 11

  1. Please enable tGrid and check them again.

@angorayc angorayc changed the title add alert consumers for useTimelineEventDetails [RAC] integrating rbac search strategy with alert flyout Aug 5, 2021
@angorayc angorayc added release_note:enhancement Team:Threat Hunting Security Solution Threat Hunting Team v7.15.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed and removed release_note:enhancement labels Aug 5, 2021
@angorayc
Copy link
Contributor Author

@elasticmachine merge upstream

@michaelolo24 michaelolo24 mentioned this pull request Aug 11, 2021
Closed
48 tasks
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 579.7KB 579.9KB +204.0B
securitySolution 6.5MB 6.5MB +2.3KB
total +2.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@angorayc angorayc marked this pull request as ready for review August 11, 2021 21:07
@angorayc angorayc requested review from a team as code owners August 11, 2021 21:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

michaelolo24
michaelolo24 approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally both the alert and hosts views and the query, pinned, and notes views in the flyout. Works great! 💪🏾

@angorayc angorayc merged commit e9ac0c6 into elastic:master Aug 12, 2021
@kibanamachine kibanamachine mentioned this pull request Aug 12, 2021
Closed
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 12, 2021
@angorayc @kibanamachine
[RAC] integrating rbac search strategy with alert flyout (elastic#107748
ef5b140 
)

* add alert consumers for useTimelineEventDetails

* set entityType to events

* rename to AlertConsumers

* set entityType to alerts

* send entity type to search strategy

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

jbudz added a commit that referenced this pull request Aug 12, 2021
@jbudz
Revert "[RAC] integrating rbac search strategy with alert flyout (#10…
2ab5c2c 
…7748)"

This reverts commit e9ac0c6.
@jbudz
Copy link
Member

jbudz commented Aug 12, 2021

This was reverted with 2ab5c2c. This is likely a timing conflict with #107573,

@kbn/rule-data-utils/target/alerts_as_data_rbac -> @kbn/rule-data-utils/target_node/alerts_as_data_rbac

https://kibana-ci.elastic.co/job/elastic+kibana+master/16219/execution/node/164/log/

@angorayc angorayc mentioned this pull request Aug 12, 2021
Merged
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 16, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 107748 or prevent reminders by adding the backport:skip label.

@angorayc
Copy link
Contributor Author

angorayc commented Aug 16, 2021 •
edited
Loading

This PR was reverted, so I didn't create a backport for it.
The I'll use the backport for #108375 instead. Therefor removing the backport-missing label for this pr.

@angorayc angorayc removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 16, 2021
@angorayc angorayc mentioned this pull request Aug 16, 2021
Merged
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 17, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 107748 or prevent reminders by adding the backport:skip label.

7 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 107748 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 107748 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 107748 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 107748 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 107748 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 107748 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 107748 or prevent reminders by adding the backport:skip label.

@spong
Copy link
Member

spong commented Aug 26, 2021

Removing backport-missing and adding backport:skip/reverted as best I can tell it looks like these changes made it into master via #108748, and 7.x (pre-cut of the 7.15 feature branch`) via #108913.

Note, these changes were subsequently merged into master via #108375, but that has also been reverted.

@spong spong added backport:skip This commit does not require backporting reverted and removed backport missing Added to PRs automatically when the are determined to be missing a backport. auto-backport Deprecated - use backport:version if exact versions are needed labels Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelolo24 michaelolo24 michaelolo24 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes reverted Team:Threat Hunting Security Solution Threat Hunting Team v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@angorayc @kibanamachine @elasticmachine @jbudz @spong @michaelolo24