[Workplace Search] Replaces success Flash Messages with Toasts #108937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottybollinger
added
release_note:skip
scottybollinger
commented
Aug 17, 2021
| @@ -239,7 +238,8 @@ export const SourceLogic = kea<MakeLogicType<SourceValues, SourceActions>>({ | |||
|
|
|||
| try { | |||
| const response = await HttpLogic.values.http.delete(route); | |||
| setQueuedSuccessMessage( | |||
| KibanaLogic.values.navigateToUrl(getSourcesPath(SOURCES_PATH, isOrganization)); | |||
There was a problem hiding this comment.
The redirect needs to occur before the toast is flashed. This wasn't working before with setQueuedSuccessMessage and should have been redirected before there as well. Verified this is working as expected with toasts
yakhinvadim
approved these changes
Aug 17, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 17, 2021
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Aug 17, 2021
…) (#108962) Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/elastic/workplace-search-team/issues/1971
Summary
This PR replaces all usages of success flash messages, and queued success flash messages with Toasts, to align with Kibana guidelines and App Search.
Checklist