-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CTI] adds Risky Host Overview Card #109553
Conversation
fd6ef9f
to
fa8d99e
Compare
@elasticmachine merge upstream |
Pinging @elastic/security-solution (Team: SecuritySolution) |
@elasticmachine merge upstream |
Hi! Just looking at the screenshots attached in the PR Description above- Is there a way to make sure that the Current Risk is sorted in descending order by default i.e. Critical -> Unknown? Sorting by the max/sum of the |
@ajosh0504 maybe this has already been addressed - but I see both scores and classifications in the card samples above. Lmk if I overlooked anything. Thanks. |
@ajosh0504 @SourinPaul @monina-n |
@elasticmachine merge upstream |
latest changes
|
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed this again after the "no dashboard" fixes were implemented. I now see the table populated independent of dashboards, and when dashboards are installed I observed the links populate. LGTM
} | ||
); | ||
|
||
export const LINK_COPY = i18n.translate('xpack.securitySolution.overview.riskyHostsSource', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use a different name here? It's a bit confusing why it's calling LINK_COPY
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, LGTM!
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
References to deprecated APIs
History
To update your PR or re-run it, just comment with: cc @ecezalp |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
testing instructions
|
Summary
Risky Hosts Overview Card
Inspect Query
Sorted by Current Risk
Updates to Threat Intel Card to match the new designs
When there are no events in the selected time range
notes to design
testing scenario
Log into the security app and visit the overview page, and confirm that there is no Risky Hosts card. Confirm that there is an updated view for the Threat Intel card. Add
xpack.securitySolution.enableExperimental: ['riskyHostsEnabled']
tokibana.dev.yml
Log into the security app and navigate to the overview page. Confirm the presence of the Risky Hosts card with a warning message and no data. Clicking the button takes the user to a documentation file on github.
if you are using a custom
.siem-signals
index as per yourkibana.dev.yml
, run the following reindex query to obtain a.siem-signals-default-*
indexnote: this step is required for properly loading
Drilldown of Host Risk Score
dashboard, as it looks for the index pattern.siem-signals-default-*
Create default .siem-signals index
Create ml_host_risk_score_latest index
Add data to ml_host_risk_score_latest index
Create ml_host_risk_score index
Create an index pattern in Kibana / Stack Management / Index Patterns. The name of the id pattern should be
ml-host-risk-score-index-pattern
, and it should point toml_host_risk_score
Navigate to Overview page and observe that the Risky Hosts data warning message has changed (it is a new message specific to data missing in current time range) dashboard buttons and source links should still be disabled at this stage.
update time range to 1 year to see the Risky Hosts card populated with data, click on column headers and arrow for sorting
Upload the Host Risk Score ndjson file into Kibana using
Stack Management
/Saved Objects
/Import
Observe that the
View Dashboard
button is now active, and clicking the button takes the user toCurrent Risk Score for Hosts
dashboard with the correct time rangeObserve that the individual links for hosts are now active, and clicking the link takes the user to
Drilldown of Host Risk Score
dashboard with the correct time range and the specific host.name applied as a filter on the page.Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers