Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AppServices] Space privilege "Index pattern management" read still shows delete button (#53682) #115390

Merged
merged 4 commits into from
Oct 21, 2021
Merged

[AppServices] Space privilege "Index pattern management" read still shows delete button (#53682) #115390

merged 4 commits into from
Oct 21, 2021

Conversation

shivindera
Copy link
Contributor

Summary

Space privilege "Index pattern management" read still shows edit and delete buttons. Also, the buttons to add new fields are not removed

Normal fields
Screenshot_20211018_165738

Scripted fields
Screenshot_20211018_165829

Checklist

Delete any items that are not applicable to this PR.

mattkime
mattkime requested changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, just a couple of comments and tests need to be fixed

...anagement/public/components/edit_index_pattern/indexed_fields_table/indexed_fields_table.tsx Outdated
IndexedFieldsTableProps,
IndexedFieldsTableState
> {
const withHooks = (Comp: any) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide types instead of using any?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

...t/public/components/edit_index_pattern/scripted_fields_table/components/table/table.test.tsx Outdated
// @ts-expect-error invalid lang type
const items: ScriptedFieldItem[] = [{ name: '1', lang: 'Elastic', script: '' }];
const items: ScriptedFieldItem[] = [
// @ts-expect-error invalid lang type
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why there's an expect error statement. Perhaps a valid lang type could be provided if thats indeed the problem.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated with a valid lang

@shivindera shivindera added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 20, 2021
@mattkime mattkime added 8.0.0 Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages labels Oct 20, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexPatternManagement 77.2KB 78.2KB +1.0KB
Unknown metric groups

References to deprecated APIs

id before after diff
indexPatternManagement 496 498 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

mattkime
mattkime approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, works well!

@jen-huang jen-huang added v8.0.0 and removed 8.0.0 labels Oct 20, 2021
@shivindera shivindera merged commit 933ece4 into elastic:master Oct 21, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 21, 2021
@shivindera @kibanamachine
[AppServices] Space privilege "Index pattern management" read still s…
48eadfc 
…hows delete button (elastic#53682) (elastic#115390)

* [AppServices] Space privilege Index pattern management read still shows delete button (elastic#53682)
@kibanamachine kibanamachine mentioned this pull request Oct 21, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.16

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 21, 2021
@kibanamachine @shivindera
[AppServices] Space privilege "Index pattern management" read still s…
3bdd9d6 
…hows delete button (#53682) (#115390) (#115899)

* [AppServices] Space privilege Index pattern management read still shows delete button (#53682)

Co-authored-by: Shivindera Singh <shivindera@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkime mattkime mattkime approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:fix v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shivindera @kibanamachine @mattkime @jen-huang