Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space privilege "Index pattern management" read still shows delete button #53682

Closed
robin13 opened this issue Dec 20, 2019 · 4 comments
Closed
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Security/Spaces Platform Security - Spaces feature impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort

Comments

@robin13
Copy link
Contributor

robin13 commented Dec 20, 2019

Kibana version: 7.5.0

Elasticsearch version: 7.5.0

Server OS version: Ubuntu 18.04

Browser version: Google Chrome Version 79.0.3945.79 (Official Build) (64-bit)

Browser OS version: Ubuntu 18.04

Original install method (e.g. download page, yum, from source, etc.): Docker

Describe the bug:

Steps to reproduce:
1.

Set up a user with the kibana spaces privilege "Index Pattern Management" set to "Read":

screenshot-2019-12-20_10-56-12

  1. Now log in with this user - when you open Index Patterns, you will (correctly) not see the edit button:

screenshot-2019-12-20_10-54-14

  1. But if you click on a given index pattern, you will see the "Delete" and "Refresh" buttons:

screenshot-2019-12-20_10-54-31

  1. When you click on these, you get a "Forbidden" error:

screenshot-2019-12-20_10-54-41

So this seems to not be a security error (the user is correctly not able to make any changes).

Expected behavior:

The UI should also hide the "delete" and "refresh" buttons for users which do not have the "edit

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@TinaHeiligers TinaHeiligers added the bug Fixes for quality problems that affect the customer experience label Dec 26, 2019
@TinaHeiligers TinaHeiligers added the Feature:Security/Spaces Platform Security - Spaces feature label Dec 26, 2019
@lukeelmers lukeelmers added the Feature:Data Views Data Views code and UI - index patterns before 8.0 label Dec 31, 2019
@lukeelmers
Copy link
Member

When addressing this, we should probably also be removing the "edit" icons next to each field, as well as the buttons for adding scripted fields and source filters.

@mattkime mattkime mentioned this issue Jul 14, 2020
12 tasks
@markov00
Copy link
Member

This still a thing in 7.8.0 (on demo.elastic.co)

I'd also like to add a few related behaviors:

  • scripted field shows also the delete button, you can press it, the scripted field is then removed from the UI (the network call fails)
  • after deleting the field and clicking the refresh field list button an error is thrown:
Error
    at Fetch._callee3$ (https://demo.elastic.co/31997/bundles/commons.bundle.js:3:1290173)
    at l (https://demo.elastic.co/31997/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:288:969217)
    at Generator._invoke (https://demo.elastic.co/31997/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:288:968970)
    at Generator.forEach.e.<computed> [as next] (https://demo.elastic.co/31997/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:288:969574)
    at asyncGeneratorStep (https://demo.elastic.co/31997/bundles/commons.bundle.js:3:1283693)
    at _next (https://demo.elastic.co/31997/bundles/commons.bundle.js:3:1284004)

looks similar to the one on this issue description

Aug-21-2020 17-50-45

  • if instead you edit the scripted field and click the save button, the network call fails silently and the Save field button progress indicator starts spinning endlessly

Screenshot 2020-08-21 at 17 46 44

@ppisljar ppisljar added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort and removed triage_needed labels Apr 29, 2021
shivindera added a commit to shivindera/kibana that referenced this issue Oct 18, 2021
shivindera added a commit that referenced this issue Oct 21, 2021
…hows delete button (#53682) (#115390)

* [AppServices] Space privilege Index pattern management read still shows delete button (#53682)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 21, 2021
…hows delete button (elastic#53682) (elastic#115390)

* [AppServices] Space privilege Index pattern management read still shows delete button (elastic#53682)
kibanamachine added a commit that referenced this issue Oct 21, 2021
…hows delete button (#53682) (#115390) (#115899)

* [AppServices] Space privilege Index pattern management read still shows delete button (#53682)

Co-authored-by: Shivindera Singh <shivindera@gmail.com>
@shivindera
Copy link
Contributor

Fixed and will be part of next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Security/Spaces Platform Security - Spaces feature impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort
Projects
None yet
Development

No branches or pull requests

8 participants