Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrations: handle 200 response code from _cluster/health API on timeout #117879

Merged
merged 2 commits into from
Nov 8, 2021
Merged

migrations: handle 200 response code from _cluster/health API on timeout #117879

merged 2 commits into from
Nov 8, 2021

Conversation

rudolf
Copy link
Contributor

@rudolf rudolf commented Nov 8, 2021 •
edited
Loading

Summary

Fixes Kibana to handle the breaking ES change introduced in elastic/elasticsearch#78968

In 7.16 this will produce a deprecation warning every time Kibana starts up, so we need to backport this fix. In the 7.x backport we also need to set the return_200_for_cluster_health_timeout=true query paramater to the cluster/_health API to prevent deprecation warnings.

Fixes #117856

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@rudolf rudolf requested a review from a team as a code owner November 8, 2021 15:57
@rudolf rudolf added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Nov 8, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@rudolf rudolf added Feature:Saved Objects bug Fixes for quality problems that affect the customer experience v7.16.0 v8.0.0 v8.1.0 labels Nov 8, 2021
@rudolf rudolf changed the title Fix test failing after ES promotion #117856 migrations: handle 200 response code from _health API on timeout Nov 8, 2021
@rudolf rudolf changed the title migrations: handle 200 response code from _health API on timeout migrations: handle 200 response code from _cluster/health API on timeout Nov 8, 2021
@rudolf rudolf added the release_note:skip Skip the PR/issue when compiling release notes label Nov 8, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

TinaHeiligers
TinaHeiligers reviewed Nov 8, 2021
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please remember to set the flag for the backport.

@TinaHeiligers TinaHeiligers self-requested a review November 8, 2021 20:04
TinaHeiligers
TinaHeiligers approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

@rudolf rudolf merged commit 853a012 into elastic:main Nov 8, 2021
@rudolf rudolf deleted the fix-es-promotion-117856 branch November 8, 2021 20:06
@rudolf rudolf added the auto-backport Deprecated - use backport:version if exact versions are needed label Nov 8, 2021
@kibanamachine kibanamachine mentioned this pull request Nov 8, 2021
Merged
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
✅ 8.0
❌ 7.16 Commit could not be cherrypicked due to conflicts

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 117879

@rudolf rudolf mentioned this pull request Nov 8, 2021
Merged
rudolf added a commit that referenced this pull request Nov 8, 2021
@rudolf
[7.16] migrations: handle 200 response code from _cluster/health API …
dff4b31 
…on timeout (#117879) (#117927)

* migrations: handle 200 response code from _cluster/health API on timeout

# Conflicts:
#	src/core/server/saved_objects/migrationsv2/actions/integration_tests/actions.test.ts

* Fix lint error
@rudolf rudolf mentioned this pull request Nov 11, 2021
Merged
9 tasks
@nreese nreese mentioned this pull request Nov 17, 2021
Closed
@rudolf rudolf mentioned this pull request Nov 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:Saved Objects release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.16.0 v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
4 participants
@rudolf @elasticmachine @kibanamachine @TinaHeiligers