[Getting Started] Adding a prominent CTA button #12003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removing "I'm a pro" link from top right. - Adding "Got it, take me to Kibana" button at bottom center. - De-emphasizing demo site.
chrisronline
approved these changes
May 25, 2017
| > | ||
| <span class="kuiButton__inner"> | ||
| <span>View the demo site</span> | ||
| <span>Got it, take me to Kibana</span> |
There was a problem hiding this comment.
Do these not need to be localized?
There was a problem hiding this comment.
Yes, they should be! Rather than increase the scope of this PR, I'll do the localization in a new PR. I've created #12004 to track it. Thanks!
ycombinator
added a commit
that referenced
this pull request
May 25, 2017
- Removing "I'm a pro" link from top right. - Adding "Got it, take me to Kibana" button at bottom center. - De-emphasizing demo site.
|
Backported to:
|
snide
pushed a commit
to snide/kibana
that referenced
this pull request
May 30, 2017
- Removing "I'm a pro" link from top right. - Adding "Got it, take me to Kibana" button at bottom center. - De-emphasizing demo site.
ycombinator
added a commit
to ycombinator/kibana
that referenced
this pull request
Jun 3, 2017
This reverts commit aa3fa06.
ycombinator
added a commit
that referenced
this pull request
Jun 5, 2017
* Revert "When on an embedded page, bypass Getting Started gate check (#12040)" This reverts commit 05293f1. * Revert "Making tweaks. (#12003)" This reverts commit aa3fa06. * Revert "Functional tests for the Getting Started page (#11850)" This reverts commit 099178a. * Revert "Prevent flicker on Getting Started page (#11826)" This reverts commit c4b3ade. * Revert "Getting Started page (#11805)" This reverts commit 32eff37. * Remove check for Getting Started page from navigateToApp
ycombinator
added a commit
that referenced
this pull request
Jun 5, 2017
* Revert "When on an embedded page, bypass Getting Started gate check (#12040)" This reverts commit 05293f1. * Revert "Making tweaks. (#12003)" This reverts commit aa3fa06. * Revert "Functional tests for the Getting Started page (#11850)" This reverts commit 099178a. * Revert "Prevent flicker on Getting Started page (#11826)" This reverts commit c4b3ade. * Revert "Getting Started page (#11805)" This reverts commit 32eff37. * Remove check for Getting Started page from navigateToApp
PopradiArpad
pushed a commit
to PopradiArpad/kibana
that referenced
this pull request
Jun 6, 2017
* Revert "When on an embedded page, bypass Getting Started gate check (elastic#12040)" This reverts commit 05293f1. * Revert "Making tweaks. (elastic#12003)" This reverts commit aa3fa06. * Revert "Functional tests for the Getting Started page (elastic#11850)" This reverts commit 099178a. * Revert "Prevent flicker on Getting Started page (elastic#11826)" This reverts commit c4b3ade. * Revert "Getting Started page (elastic#11805)" This reverts commit 32eff37. * Remove check for Getting Started page from navigateToApp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Resolves #11809.
Before this PR
After this PR