Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Getting Started] Adding a prominent CTA button #12003

Merged
merged 1 commit into from
May 25, 2017
Merged

[Getting Started] Adding a prominent CTA button #12003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 19 additions & 25 deletions src/core_plugins/getting_started/public/components/getting_started/getting_started.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,6 @@
class="kuiViewContent gettingStartedContent"
data-test-subj="gettingStartedContainer"
>

<div
ng-if="!gettingStarted.hasOptedOut()"
class="kuiBar gettingStartedOptOutContent"
>
<div class="kuiBarSection">
<p class="kuiText kuiSubduedText">
<a
kbn-href="#/management"
class="kuiLink"
kbn-getting-started-opt-out
data-test-subj="lnkGettingStartedOptOut"
>I'm a pro, skip this stuff &gt;</a>
</p>
</div>
</div>

<div class="kuiViewContentItem kuiVerticalRhythm gettingStartedWelcome">
<h1 class="kuiTitle gettingStartedTitle">
Welcome to Kibana
Expand Down Expand Up @@ -149,26 +132,37 @@ <h2 class="kuiSubTitle">
</div>
</div>

<div class="kuiViewContentItem kuiVerticalRhythm">
<div
ng-if="!gettingStarted.hasOptedOut()"
class="kuiViewContentItem kuiVerticalRhythm"
>
<div class="kuiFieldGroup">
<div class="kuiFieldGroupSection">
<p class="kuiText">Just want to see what Kibana is capable of doing?</p>
</div>

<div class="kuiFieldGroupSection">
<a
class="kuiButton kuiButton--primary"
ng-href="{{ gettingStarted.documentationLinks.demoSite }}"
target="_blank"
kbn-href="#/management"
kbn-getting-started-opt-out
data-test-subj="lnkGettingStartedOptOut"
>
<span class="kuiButton__inner">
<span>View the demo site</span>
<span>Got it, take me to Kibana</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these not need to be localized?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they should be! Rather than increase the scope of this PR, I'll do the localization in a new PR. I've created #12004 to track it. Thanks!

</span>
</a>
</div>
</div>
</div>

<div class="kuiViewContentItem kuiVerticalRhythm">
<p class="kuiText">
Just want to see what Kibana is capable of doing?
<a
ng-href="{{ gettingStarted.documentationLinks.demoSite }}"
class="kuiLink"
target="_blank"
>View the demo site</a>.
</p>
</div>

<div class="kuiViewContentItem kuiVerticalRhythm">
<p class="kuiText">
<a
Expand Down
6 changes: 0 additions & 6 deletions src/core_plugins/getting_started/public/components/getting_started/getting_started.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,6 @@
padding-top: 0;
}

.gettingStartedOptOutContent {
position: absolute;
top: 20px;
right: 30px;
}

.gettingStartedWelcome {
display: flex;
flex-direction: column;
Expand Down