Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Maps: Add query support to anomalies layer #123988

Merged

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Jan 28, 2022

Summary

Adds query support for the anomalies layer in maps, allowing filtering on the partitioning field values used in the anomaly detection job.

image

Related meta issue: #123492

Checklist

Delete any items that are not applicable to this PR.

@alvarezmelissa87 alvarezmelissa87 added :ml release_note:skip Skip the PR/issue when compiling release notes v8.1.0 labels Jan 28, 2022
@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner January 28, 2022 02:23
@alvarezmelissa87 alvarezmelissa87 self-assigned this Jan 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.5MB 3.5MB -7.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
ml 38.9KB 38.8KB -28.0B
Unknown metric groups

async chunk count

id before after diff
ml 27 24 -3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM.

Is it possible to add in filtering buttons into this Maps popover? If so, that would be a really good way of quick filtering for a particular anomalous partitioning field name / value.

image

Also would be nice to add influencer fields into that popover, which could open up extra filtering options.

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qn895
Copy link
Member

qn895 commented Jan 28, 2022

Code LGTM 🎉

@alvarezmelissa87 alvarezmelissa87 merged commit a927e82 into elastic:main Jan 28, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 28, 2022
@alvarezmelissa87 alvarezmelissa87 deleted the ml-maps-query-support branch January 28, 2022 20:05
awahab07 pushed a commit to awahab07/kibana that referenced this pull request Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants