Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unified search] Improves the current filter/search experience #128401

Merged
merged 73 commits into from
May 6, 2022
Merged
Show file tree
Hide file tree
Changes from 70 commits
Commits
Show all changes
73 commits
Select commit Hold shift + click to select a range
0271e79
[Unified search] Moves dataview picker to the search bar (#126560)
stratoula Mar 21, 2022
a658848
Merge branch 'main' into unified-search-1
stratoula Mar 22, 2022
391b3b5
Merge branch 'main' into unified-search-1
stratoula Mar 23, 2022
ca79be1
Merge branch 'main' into unified-search-1
stratoula Mar 28, 2022
ac9bf8e
Merge branch 'main' into unified-search-1
stratoula Mar 29, 2022
78b52a0
fix test
stratoula Mar 29, 2022
aacc187
Merge branch 'main' into unified-search-1
stratoula Mar 30, 2022
e7498fa
Merge branch 'main' into unified-search-1
stratoula Mar 31, 2022
d67380c
Merge branch 'main' into unified-search-1
stratoula Apr 1, 2022
110067c
Fix CI
stratoula Apr 1, 2022
225ce94
Merge branch 'main' into unified-search-1
kibanamachine Apr 4, 2022
4811ecd
Merge with main and resolve conflicts
stratoula Apr 5, 2022
f9e6696
Fix i18n checks
stratoula Apr 5, 2022
882f862
Merge branch 'main' into unified-search-1
stratoula Apr 7, 2022
24fafbb
Merge branch 'main' into unified-search-1
stratoula Apr 11, 2022
78c151e
Merge with main and resolve conflicts
stratoula Apr 12, 2022
7ad845a
[Unified search] Redesign search bar (#126566)
stratoula Apr 12, 2022
182b8cb
Merge with main and resolve conflcits
stratoula Apr 13, 2022
53e7877
Fix jest
stratoula Apr 13, 2022
6603b29
Fix jest tests
stratoula Apr 13, 2022
3d8c255
Merge with ES lint commit
stratoula Apr 18, 2022
93a2184
Merge with main and resolve conflicts
stratoula Apr 18, 2022
0599d9d
Stabilize discover security tests
stratoula Apr 18, 2022
8e0167c
Merge branch 'main' into unified-search-1
stratoula Apr 20, 2022
3ef6fb1
[Unified search] Further enhancements (#129877)
stratoula Apr 20, 2022
232d885
Merge with main and resolve conflicts
stratoula Apr 21, 2022
0ae9b70
Fix translations
stratoula Apr 21, 2022
1e14bcc
Merge branch 'main' into unified-search-1
kibanamachine Apr 21, 2022
1a753b6
Fix security solution add filter bug
stratoula Apr 21, 2022
7f8ea11
Merge branch 'main' into unified-search-1
kibanamachine Apr 21, 2022
37d2f24
Filter bar / items: Reduce to only necessary wrappers and styles
Apr 14, 2022
3c8985f
Fix styles by removing styled-components
Apr 14, 2022
cfbd22a
Refactor `SearchBar` and `QueryBarTopRow` a bit
Apr 14, 2022
f304d53
Update usages
Apr 14, 2022
91264f4
Fix a test
Apr 21, 2022
7b2ed98
Fix jest test
stratoula Apr 21, 2022
ee0413b
Attaches filter menu when no add button and better dropdown styles
Apr 21, 2022
d8006ad
Fix lint errors
stratoula Apr 22, 2022
9a0c7cc
Clearing the query and filters of a saved query should unload the sav…
stratoula Apr 22, 2022
d89f3ba
Do not allow to update the loaded saved query if no filters or no query
stratoula Apr 22, 2022
f7ee3c4
Fix Graph by creating reusable `KibanaFilterButtonGroup`
Apr 25, 2022
b9b19f8
Use EuiTheme for SearchBar styles
Apr 26, 2022
6867bea
Fix displayStyle prop problem
stratoula Apr 26, 2022
1bb1065
Correct alignment of data visualizer
stratoula Apr 26, 2022
7074fc1
Super nit comment
stratoula Apr 26, 2022
340e0d4
Merge with main and resolve conflicts
stratoula Apr 28, 2022
40bb170
Data visualizer improvements
stratoula Apr 28, 2022
54f868c
Apply useMemo in editPermission cont in Discover
stratoula Apr 28, 2022
8f9d6e2
Fix translations checks
stratoula Apr 28, 2022
b61d61e
Fix translations checks
stratoula Apr 28, 2022
5dbf763
Fix filter badge popover bug
stratoula Apr 28, 2022
c278f67
[Submit button] Changed to EuiSuperUpdateButton
Apr 28, 2022
a0d3539
Fix tests
stratoula Apr 28, 2022
1adaee6
Align the position with the other tolltips and check that functional …
stratoula Apr 28, 2022
29a09c6
Give some time to the tooltip to disappear
stratoula Apr 28, 2022
160bd76
Merge branch 'main' into unified-search-1
kibanamachine Apr 28, 2022
973ad0e
Merge branch 'main' into unified-search-1
stratoula Apr 29, 2022
6843fef
Fix tests
stratoula Apr 29, 2022
e814fa1
Merge branch 'main' into unified-search-1
stratoula May 3, 2022
b76c8f4
Merge with main and resolve conflicts
stratoula May 3, 2022
bc0d302
Fix CI checks
stratoula May 3, 2022
504d706
Merge branch 'main' into unified-search-1
stratoula May 3, 2022
0a72bc1
Address PR comments
stratoula May 4, 2022
e86baaf
Move constants outside render
stratoula May 4, 2022
10b616a
Apply PR comments
stratoula May 4, 2022
42ae00c
Fix dataview picker glich
stratoula May 4, 2022
108f0ad
Merge with main and resolve conflicta
stratoula May 4, 2022
eca5885
lovercase emotion function
stratoula May 4, 2022
e9f03b1
Fix a11y problem on dataview picker
stratoula May 4, 2022
92f9ad0
Lowercase rest of emotion style functions
stratoula May 4, 2022
e398ced
Merge branch 'main' into unified-search-1
stratoula May 5, 2022
c865ad0
Clean up
stratoula May 5, 2022
54d2949
Merge branch 'main' into unified-search-1
stratoula May 6, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .buildkite/scripts/steps/storybooks/build_and_upload.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ const STORYBOOKS = [
'security_solution',
'shared_ux',
'ui_actions_enhanced',
'unified_search',
];

const GITHUB_CONTEXT = 'Build and Publish Storybooks';
Expand Down
2 changes: 1 addition & 1 deletion packages/kbn-babel-preset/styled_components_files.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ module.exports = {
*/
USES_STYLED_COMPONENTS: [
/packages[\/\\]kbn-ui-shared-deps-(npm|src)[\/\\]/,
/src[\/\\]plugins[\/\\](unified_search|kibana_react)[\/\\]/,
/src[\/\\]plugins[\/\\](kibana_react)[\/\\]/,
/x-pack[\/\\]plugins[\/\\](apm|beats_management|cases|fleet|infra|lists|observability|osquery|security_solution|timelines|synthetics|ux)[\/\\]/,
/x-pack[\/\\]test[\/\\]plugin_functional[\/\\]plugins[\/\\]resolver_test[\/\\]/,
],
Expand Down
1 change: 1 addition & 0 deletions src/dev/storybook/aliases.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

// Please also add new aliases to test/scripts/jenkins_storybook.sh
export const storybookAliases = {
unified_search: 'src/plugins/unified_search/.storybook',
stratoula marked this conversation as resolved.
Show resolved Hide resolved
coloring: 'packages/kbn-coloring/.storybook',
apm: 'x-pack/plugins/apm/.storybook',
canvas: 'x-pack/plugins/canvas/storybook',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,7 @@ export function DashboardTopNav({
const showQueryInput = shouldShowNavBarComponent(Boolean(embedSettings?.forceShowQueryInput));
const showDatePicker = shouldShowNavBarComponent(Boolean(embedSettings?.forceShowDatePicker));
const showFilterBar = shouldShowFilterBar(Boolean(embedSettings?.forceHideFilterBar));
const showQueryBar = showQueryInput || showDatePicker;
const showQueryBar = showQueryInput || showDatePicker || showFilterBar;
const showSearchBar = showQueryBar || showFilterBar;
const screenTitle = dashboardState.title;

Expand Down
1 change: 1 addition & 0 deletions src/plugins/data/public/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ export interface IDataPluginServices extends Partial<CoreStart> {
uiSettings: CoreStart['uiSettings'];
savedObjects: CoreStart['savedObjects'];
notifications: CoreStart['notifications'];
application: CoreStart['application'];
http: CoreStart['http'];
storage: IStorageWrapper;
data: DataPublicPluginStart;
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
* Side Public License, v 1.
*/

import './test_script.scss';

import React, { Component, Fragment } from 'react';

import {
Expand Down Expand Up @@ -223,8 +221,11 @@ export class TestScript extends Component<TestScriptProps, TestScriptState> {
/>
</EuiFormRow>

<EuiSpacer size="s" />

<div className="testScript__searchBar">
<this.context.services.unifiedSearch.ui.SearchBar
displayStyle="inPage"
appName={'indexPatternManagement'}
showFilterBar={false}
showDatePicker={false}
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/discover/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"dataViewEditor"
],
"optionalPlugins": ["home", "share", "usageCollection", "spaces", "triggersActionsUi"],
"requiredBundles": ["kibanaUtils", "kibanaReact", "dataViews"],
"requiredBundles": ["kibanaUtils", "kibanaReact", "dataViews", "unifiedSearch"],
"extraPublicDirs": ["common"],
"owner": {
"name": "Data Discovery",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ describe('ContextApp test', () => {
const topNavProps = {
appName: 'context',
showSearchBar: true,
showQueryBar: false,
showQueryBar: true,
showQueryInput: false,
showFilterBar: true,
showSaveQuery: false,
showDatePicker: false,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,8 @@ export const ContextApp = ({ indexPattern, anchorId }: ContextAppProps) => {
return {
appName: 'context',
showSearchBar: true,
showQueryBar: false,
showQueryBar: true,
showQueryInput: false,
showFilterBar: true,
showSaveQuery: false,
showDatePicker: false,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,14 @@ discover-app {

.dscPageBody__contents {
overflow: hidden;
padding-top: $euiSizeXS / 2; // A little breathing room for the index pattern button
}

.dscPageContent__wrapper {
padding: 0 $euiSize $euiSize 0;
padding: $euiSizeS $euiSizeS $euiSizeS 0;
overflow: hidden; // Ensures horizontal scroll of table

@include euiBreakpoint('xs', 's') {
padding: 0 $euiSize $euiSize;
padding: 0 $euiSizeS $euiSizeS;
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,9 @@ export function DiscoverLayout({
stateContainer={stateContainer}
updateQuery={onUpdateQuery}
resetSavedSearch={resetSavedSearch}
onChangeIndexPattern={onChangeIndexPattern}
onEditRuntimeField={onEditRuntimeField}
useNewFieldsApi={useNewFieldsApi}
/>
<EuiPageBody className="dscPageBody" aria-describedby="savedSearchTitle">
<SavedSearchURLConflictCallout
Expand All @@ -245,7 +248,7 @@ export function DiscoverLayout({
defaultMessage: 'Discover - Search not yet saved',
})}
</h1>
<EuiFlexGroup className="dscPageBody__contents" gutterSize="none">
<EuiFlexGroup className="dscPageBody__contents" gutterSize="s">
<EuiFlexItem grow={false}>
<SidebarMemoized
columns={columns}
Expand Down

This file was deleted.

Loading