-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[plugin-discovery] move logic to a package #128684
[plugin-discovery] move logic to a package #128684
Conversation
Pinging @elastic/kibana-operations (Team:Operations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build SucceededMetrics [docs]Public APIs missing comments
Unknown metric groupsAPI count
ESLint disabled in files
ESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
(cherry picked from commit 92d6548) # Conflicts: # .github/CODEOWNERS # package.json # packages/kbn-type-summarizer/src/lib/bazel_cli_config.ts
Part of #94034
This PR moved the plugin discovery logic to a new package so that we can import it in
@kbn/pm
, which copies all imported sources into thepackages/kbn-pm/dist/index.js
file, so isolating the logic in a package is necessary to prevent constant unnecessary rebuilds of this dist file.