Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin-discovery] move logic to a package #128684

Merged
merged 8 commits into from
Mar 29, 2022

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Mar 28, 2022

Part of #94034

This PR moved the plugin discovery logic to a new package so that we can import it in @kbn/pm, which copies all imported sources into the packages/kbn-pm/dist/index.js file, so isolating the logic in a package is necessary to prevent constant unnecessary rebuilds of this dist file.

@spalger spalger added Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 v8.1.2 labels Mar 28, 2022
@spalger spalger marked this pull request as ready for review March 28, 2022 22:56
@spalger spalger requested review from a team as code owners March 28, 2022 22:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/dev-utils 207 199 -8
@kbn/plugin-discovery - 27 +27
total +19
Unknown metric groups

API count

id before after diff
@kbn/dev-utils 286 277 -9
@kbn/plugin-discovery - 28 +28
total +19

ESLint disabled in files

id before after diff
apm 15 14 -1
osquery 5 4 -1
securitySolution 69 68 -1
uptime 7 6 -1
total -4

ESLint disabled line counts

id before after diff
apm 88 85 -3
enterpriseSearch 9 7 -2
fleet 47 46 -1
osquery 122 119 -3
uptime 49 43 -6
total -15

References to deprecated APIs

id before after diff
canvas 70 64 -6
dashboard 78 72 -6
data 475 465 -10
dataEnhanced 55 49 -6
discover 26 20 -6
fleet 20 19 -1
lens 18 14 -4
management 2 1 -1
maps 456 330 -126
monitoring 40 28 -12
upgradeAssistant 12 7 -5
visDefaultEditor 205 155 -50
visTypeVega 4 3 -1
visualizations 17 13 -4
total -238

Total ESLint disabled count

id before after diff
apm 103 99 -4
enterpriseSearch 9 7 -2
fleet 55 54 -1
osquery 127 123 -4
securitySolution 509 508 -1
uptime 56 49 -7
total -19

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit 92d6548 into elastic:main Mar 29, 2022
@spalger spalger deleted the implement/plugin-discovery-package branch March 29, 2022 19:19
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.1 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 128684

Questions ?

Please refer to the Backport tool documentation

spalger pushed a commit to spalger/kibana that referenced this pull request Mar 29, 2022
(cherry picked from commit 92d6548)

# Conflicts:
#	.github/CODEOWNERS
#	package.json
#	packages/kbn-type-summarizer/src/lib/bazel_cli_config.ts
spalger pushed a commit that referenced this pull request Mar 29, 2022
(cherry picked from commit 92d6548)

# Conflicts:
#	.github/CODEOWNERS
#	package.json
#	packages/kbn-type-summarizer/src/lib/bazel_cli_config.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.1.2 v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants