Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.1] [plugin-discovery] move logic to a package (#128684) #128817

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Mar 29, 2022

Backport

This will backport the following commits from main to 8.1:

Questions ?

Please refer to the Backport tool documentation

(cherry picked from commit 92d6548)

# Conflicts:
#	.github/CODEOWNERS
#	package.json
#	packages/kbn-type-summarizer/src/lib/bazel_cli_config.ts
@spalger spalger enabled auto-merge (squash) March 29, 2022 19:37
@spalger spalger merged commit 0f6d770 into elastic:8.1 Mar 29, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/dev-utils 207 199 -8
@kbn/plugin-discovery - 27 +27
total +19
Unknown metric groups

API count

id before after diff
@kbn/dev-utils 286 277 -9
@kbn/plugin-discovery - 28 +28
total +19

ESLint disabled in files

id before after diff
apm 15 14 -1
osquery 5 4 -1
securitySolution 68 67 -1
uptime 5 4 -1
total -4

ESLint disabled line counts

id before after diff
apm 94 91 -3
enterpriseSearch 7 6 -1
osquery 121 118 -3
uptime 48 42 -6
total -13

References to deprecated APIs

id before after diff
canvas 70 64 -6
dashboard 90 84 -6
data 487 477 -10
dataEnhanced 49 43 -6
dataViewFieldEditor 25 14 -11
discover 219 201 -18
fleet 14 10 -4
lens 237 185 -52
management 2 1 -1
maps 1298 817 -481
monitoring 53 41 -12
screenshotting 12 8 -4
stackAlerts 183 157 -26
upgradeAssistant 8 3 -5
visDefaultEditor 205 155 -50
visTypeTimeseries 427 377 -50
visTypeVega 25 24 -1
visualizations 114 100 -14
total -757

Total ESLint disabled count

id before after diff
apm 109 105 -4
enterpriseSearch 7 6 -1
osquery 126 122 -4
securitySolution 513 512 -1
uptime 53 46 -7
total -17

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger deleted the backport/8.1/pr-128684 branch March 29, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants