Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Rule Preview Table Follow-up #128981

Merged
merged 20 commits into from
Apr 11, 2022
Merged

[Security Solution] Rule Preview Table Follow-up #128981

merged 20 commits into from
Apr 11, 2022

Conversation

dplumlee
Copy link
Contributor

@dplumlee dplumlee commented Mar 30, 2022 •
edited
Loading

Summary

Previous PR: #127986

Fixes some known bugs in the previous rule preview table PR including:

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@dplumlee dplumlee added release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Feature:Detection Rule Preview Security Solution Rule Preview Team:Detection Alerts Security Detection Alerts Area Team v8.2.0 labels Mar 30, 2022
@dplumlee dplumlee self-assigned this Mar 30, 2022
@dplumlee dplumlee force-pushed the rule-preview-follow-up branch 3 times, most recently from bbb7c16 to be583b0 Compare April 5, 2022 20:13
dplumlee
dplumlee commented Apr 6, 2022
View reviewed changes
x-pack/plugins/security_solution/common/detection_engine/constants.ts
@@ -6,7 +6,7 @@
*/

export enum RULE_PREVIEW_INVOCATION_COUNT {
HOUR = 20,
HOUR = 12,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone (me) couldn't do basic math it seems 😢

@dplumlee dplumlee mentioned this pull request Apr 6, 2022
Closed
@dplumlee dplumlee force-pushed the rule-preview-follow-up branch 2 times, most recently from 4263fab to fb68d73 Compare April 6, 2022 23:31
@dplumlee dplumlee added the bug Fixes for quality problems that affect the customer experience label Apr 6, 2022
@dplumlee dplumlee marked this pull request as ready for review April 6, 2022 23:32
@dplumlee dplumlee requested review from a team as code owners April 6, 2022 23:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@dplumlee
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

expected head sha didn’t match current head ref.

kqualters-elastic
kqualters-elastic reviewed Apr 11, 2022
View reviewed changes
...gins/security_solution/public/detections/components/rules/rule_preview/preview_histogram.tsx Outdated
dataProviders,
defaultColumns,
deletedEventIds,
graphEventId, // If truthy, the graph viewer (Resolver) is showing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably don't need this, and if you do, https://github.com/elastic/kibana/blob/main/x-pack/plugins/timelines/public/components/t_grid/integrated/index.tsx#L116 should be graphEventId?: string; instead

@dplumlee dplumlee enabled auto-merge (squash) April 11, 2022 19:01
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #9 / maps app auto fit map to bounds initial location should automatically fit to bounds on initial map load

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.8MB 4.8MB -251.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 251.8KB 251.8KB +54.0B
timelines 286.7KB 286.8KB +54.0B
total +108.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 446 447 +1

Total ESLint disabled count

id before after diff
securitySolution 515 516 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dplumlee

@dplumlee dplumlee merged commit 268470a into elastic:main Apr 11, 2022
@dplumlee dplumlee added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 11, 2022
@kibanamachine kibanamachine mentioned this pull request Apr 11, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Apr 11, 2022
@dplumlee
[Security Solution] Rule Preview Table Follow-up (#128981)
be53e5f 
(cherry picked from commit 268470a)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Apr 12, 2022
Merged
kibanamachine added a commit that referenced this pull request Apr 12, 2022
@kibanamachine @dplumlee
[8.2] [Security Solution] Rule Preview Table Follow-up (#128981) (#12…
64b05e6 
…9941)

* [Security Solution] Rule Preview Table Follow-up (#128981)

(cherry picked from commit 268470a)

* fixes test breaking

Co-authored-by: Davis Plumlee <56367316+dplumlee@users.noreply.github.com>
Co-authored-by: Davis Plumlee <davis.plumlee@elastic.co>
@dplumlee dplumlee deleted the rule-preview-follow-up branch April 12, 2022 20:19
@dplumlee dplumlee mentioned this pull request Jul 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kqualters-elastic kqualters-elastic kqualters-elastic approved these changes

Assignees

@dplumlee dplumlee

Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:Detection Rule Preview Security Solution Rule Preview release_note:skip Skip the PR/issue when compiling release notes Team:Detection Alerts Security Detection Alerts Area Team Team:Detections and Resp Security Detection Response Team v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dplumlee @elasticmachine @kibanamachine @kibana-ci @kqualters-elastic