Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA][Code Coverage] Drop dead shell scripts, update docs #129565

Merged
merged 1 commit into from
Apr 7, 2022
Merged

[QA][Code Coverage] Drop dead shell scripts, update docs #129565

merged 1 commit into from
Apr 7, 2022

Conversation

wayneseymour
Copy link
Member

Summary

While searching the ingestion system
for any upcoming deprecations,
I noticed these scripts are no longer used.

@wayneseymour
[QA][Code Coverage] Drop dead shell scripts, update docs
2d86f6e 
While searching the ingestion system
for any [upcoming deprecations](#129087), I
noticed these scripts are no longer used.
@wayneseymour wayneseymour added Team:QA Team label for QA Team release_note:skip Skip the PR/issue when compiling release notes code coverage Issues & PRs about code coverage v8.2.0 labels Apr 6, 2022
@wayneseymour wayneseymour self-assigned this Apr 6, 2022
@wayneseymour
Copy link
Member Author

Run against code coverage and see if dropping these scripts breaks anything: https://buildkite.com/elastic/kibana-code-coverage-main/builds/256

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #10 / Actions and Triggers app Rule Details Header should reenable a disabled the rule

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @wayneseymour

@wayneseymour wayneseymour marked this pull request as ready for review April 6, 2022 16:13
@wayneseymour wayneseymour requested a review from a team as a code owner April 6, 2022 16:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

marius-dr
marius-dr approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@marius-dr marius-dr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wayneseymour wayneseymour merged commit 401ad52 into main Apr 7, 2022
@wayneseymour wayneseymour deleted the drop-dead-shell-scripts-update-docs branch April 7, 2022 16:03
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 129565 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 11, 2022
@wayneseymour wayneseymour added the backport:skip This commit does not require backporting label Apr 11, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marius-dr marius-dr marius-dr approved these changes

Assignees

@wayneseymour wayneseymour

Labels
backport:skip This commit does not require backporting code coverage Issues & PRs about code coverage release_note:skip Skip the PR/issue when compiling release notes Team:QA Team label for QA Team v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wayneseymour @kibana-ci @elasticmachine @kibanamachine @marius-dr