Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA][Code Coverage] Drop dead shell scripts, update docs #129565

Merged
merged 1 commit into from
Apr 7, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/dev/code_coverage/docs/team_assignment/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@

Team assignment occurs once per ci run.

The "orchestration" entry point is a [Jenkinsfile Scripted Pipeline](https://github.com/elastic/kibana/blob/f73bc48b3bbbb5ad2042c1aa267aea2150b7b742/.ci/Jenkinsfile_coverage#L21)
This Jenkinsfile runs a [shell script](https://github.com/elastic/kibana/blob/main/src/dev/code_coverage/shell_scripts/generate_team_assignments_and_ingest_coverage.sh#L33) that kicks everything off.
The end result is the data is ingested to our [Kibana Stats Cluster](https://kibana-stats.elastic.dev/app/dashboards#/view/58b8db70-62f9-11ea-8312-7f2d69b79843?_g=(filters%3A!()%2CrefreshInterval%3A(pause%3A!t%2Cvalue%3A0)%2Ctime%3A(from%3Anow-7d%2Cto%3Anow)))
The entry point is a [yaml config](https://buildkite.com/elastic/kibana-code-coverage-main/steps)
Within the yaml config, [this shell script](https://github.com/elastic/kibana/blob/main/.buildkite/scripts/steps/code_coverage/reporting/ingestData.sh) is used.
Search for `node scripts/generate_team_assignments.js` and you'll see how it is generated before ingestion begins.
The generated file's path is passed to the ingestion system via an environment variable: `--teamAssignmentsPath $TEAM_ASSIGN_PATH`
The ingestion system uses it [here](https://github.com/elastic/kibana/blob/main/src/dev/code_coverage/ingest_coverage/index.js#L33).

## Team Assignment Parsing (from .github/CODEOWNERS)
We add additional metadata to the CODEOWNERS file.
Expand Down
10 changes: 0 additions & 10 deletions src/dev/code_coverage/shell_scripts/copy_jest_report.sh

This file was deleted.

12 changes: 0 additions & 12 deletions src/dev/code_coverage/shell_scripts/extract_archives.sh

This file was deleted.

7 changes: 0 additions & 7 deletions src/dev/code_coverage/shell_scripts/extract_xpack_tests.sh

This file was deleted.

This file was deleted.

24 changes: 0 additions & 24 deletions src/dev/code_coverage/shell_scripts/merge_functional.sh

This file was deleted.