Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip ESTF failures #136912

Merged
merged 3 commits into from
Jul 22, 2022
Merged

Skip ESTF failures #136912

merged 3 commits into from
Jul 22, 2022

Conversation

matschaffer
Copy link
Contributor

@matschaffer matschaffer commented Jul 22, 2022 •
edited by kibanamachine
Loading

Summary

Fixes 5 new ESTF failure issues all exhibiting this diff.

[00:02:31]                         │              "apms": {
[00:02:31]                         │                "total": 0
[00:02:31]                         │              }
[00:02:31]                         │              "config": {
[00:02:31]                         │       -        "container": true
[00:02:31]                         │       +        "container": false
[00:02:31]                         │              }
[00:02:31]                         │              "memRss": 0
[00:02:31]                         │              "totalEvents": 0
[00:02:31]                         │              "versions": []

This arrises from the API integration tests being run on cloud (in containers) while the archive data for assertions is not from a containerized system.

Fixes #136878
Fixes #136879
Fixes #136880
Fixes #136893
Fixes #136894
Fixes #105355
Fixes #105356
Fixes #98419
Fixes #105357
Fixes #98420

@matschaffer matschaffer added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services backport:all-open Backport to all branches that could still receive a release labels Jul 22, 2022
@matschaffer matschaffer requested a review from liza-mae July 22, 2022 03:26
@matschaffer matschaffer requested a review from a team as a code owner July 22, 2022 03:26
@matschaffer matschaffer self-assigned this Jul 22, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@matschaffer matschaffer added the release_note:skip Skip the PR/issue when compiling release notes label Jul 22, 2022
@matschaffer matschaffer enabled auto-merge (squash) July 22, 2022 04:34
@matschaffer
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @matschaffer

miltonhultgren
miltonhultgren approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@miltonhultgren miltonhultgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be nice if we could easily regenerate archives on the fly to account for different contexts? :D

x-pack/test/api_integration/apis/monitoring/apm/instance_mb.js
@@ -12,7 +12,10 @@ import { getLifecycleMethods } from '../data_stream';
export default function ({ getService }) {
const supertest = getService('supertest');

describe('instance detail mb', () => {
describe('instance detail mb', function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for swapping to function, rather than arrow function?

Copy link
Contributor Author

@matschaffer matschaffer Jul 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be nice if we could easily regenerate archives on the fly to account for different contexts? :D

I see what you did there ;)

Is there a reason for swapping to function, rather than arrow function?

As far as I know you need this in order to add test tags. But I could switch it if you know another way to add the tags.

liza-mae
liza-mae approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@liza-mae liza-mae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matschaffer matschaffer merged commit 63c7bee into elastic:main Jul 22, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 22, 2022
@matschaffer
Skip ESTF failures (elastic#136912)
8a6544f 
* Skip ESTF failures

* Right, can't tag stabby lambdas

(cherry picked from commit 63c7bee)
@kibanamachine kibanamachine mentioned this pull request Jul 22, 2022
Merged
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ 7.17 Backport failed because of merge conflicts
✅ 8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 136912

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 22, 2022
@kibanamachine @matschaffer
Skip ESTF failures (#136912) (#136978)
51ff3b8 
* Skip ESTF failures

* Right, can't tag stabby lambdas

(cherry picked from commit 63c7bee)

Co-authored-by: Mat Schaffer <mat@elastic.co>
matschaffer added a commit to matschaffer/kibana that referenced this pull request Jul 25, 2022
@matschaffer
Skip ESTF failures (elastic#136912)
0c0b69c 
* Skip ESTF failures

* Right, can't tag stabby lambdas

(cherry picked from commit 63c7bee)

# Conflicts:
#	x-pack/test/api_integration/apis/monitoring/apm/instance_mb.js
#	x-pack/test/api_integration/apis/monitoring/apm/instances_mb.js
@matschaffer matschaffer mentioned this pull request Jul 25, 2022
Merged
@matschaffer
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

matschaffer added a commit that referenced this pull request Jul 25, 2022
@matschaffer
Skip ESTF failures (#136912) (#137026)
21e94e1 
* Skip ESTF failures

* Right, can't tag stabby lambdas

(cherry picked from commit 63c7bee)

# Conflicts:
#	x-pack/test/api_integration/apis/monitoring/apm/instance_mb.js
#	x-pack/test/api_integration/apis/monitoring/apm/instances_mb.js
@crespocarlos crespocarlos mentioned this pull request Aug 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miltonhultgren miltonhultgren miltonhultgren approved these changes

@liza-mae liza-mae liza-mae approved these changes

Assignees

@matschaffer matschaffer

Labels
backport:all-open Backport to all branches that could still receive a release release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.17.6 v8.3.3 v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[test-failed]: X-Pack API Integration Tests1.x-pack/test/api_integration/apis/monitoring/cluster/list_mb·js - apis Monitoring cluster list mb with trial license clusters should load multiple clusters [test-failed]: X-Pack API Integration Tests1.x-pack/test/api_integration/apis/monitoring/apm/instance_mb·js - apis Monitoring APM instance detail mb should get apm instance data [test-failed]: X-Pack API Integration Tests1.x-pack/test/api_integration/apis/monitoring/apm/instances_mb·js - apis Monitoring APM list mb should load multiple clusters [test-failed]: X-Pack API Integration Tests1.x-pack/test/api_integration/apis/monitoring/standalone_cluster/cluster·js - apis Monitoring Standalone Cluster cluster should get cluster data [test-failed]: X-Pack API Integration Tests1.x-pack/test/api_integration/apis/monitoring/cluster/list·js - apis Monitoring cluster list with trial license clusters should load multiple clusters
[test-failed]: X-Pack API Integration Tests.x-pack/test/api_integration/apis/monitoring/cluster/list·js - apis Monitoring cluster list with trial license clusters should load multiple clusters [test-failed]: X-Pack API Integration Tests.x-pack/test/api_integration/apis/monitoring/cluster/list_mb·js - apis Monitoring cluster list mb with trial license clusters should load multiple clusters [test-failed]: X-Pack API Integration Tests.x-pack/test/api_integration/apis/monitoring/standalone_cluster/cluster·js - apis Monitoring Standalone Cluster cluster should get cluster data [test-failed]: X-Pack API Integration Tests.x-pack/test/api_integration/apis/monitoring/apm/instances_mb·js - apis Monitoring APM list mb should load multiple clusters [test-failed]: X-Pack API Integration Tests.x-pack/test/api_integration/apis/monitoring/apm/instance_mb·js - apis Monitoring APM instance detail mb should get apm instance data
6 participants
@matschaffer @elasticmachine @kibana-ci @kibanamachine @miltonhultgren @liza-mae