[Stack Monitoring] Fix Kibana rules and actions integration test #138090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crespocarlos
force-pushed
the
137739-estf-test-skip
branch
from
e11ed98 to
95efcd3
Compare
crespocarlos
commented
Aug 8, 2022
| const { body } = await supertest | ||
| .post('/api/monitoring/v1/clusters/SvjwrFv6Rvuqjm9-cSSVEg') | ||
| .set('kbn-xsrf', 'xxx') | ||
| .send({ timeRange, codePaths: ['all'] }) | ||
| .expect(200); | ||
| expect(body).to.eql(fixture); | ||
|
|
||
| expect(body[0].kibana.rules).to.eql(fixture[0].kibana.rules); |
There was a problem hiding this comment.
rules is the most important things to be validated by this test, based on the documents that are created by the archiver.
crespocarlos
changed the title
crespocarlos
added
backport:prev-minor
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
|
@elasticmachine merge upstream |
miltonhultgren
approved these changes
Aug 8, 2022
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 8, 2022
…stic#138090) * Skip rules and actions integration tests for esft test runs * Change what is validated in the kibana rules unit test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 9cc5037)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 8, 2022
…stic#138090) (elastic#138269) * Skip rules and actions integration tests for esft test runs * Change what is validated in the kibana rules unit test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 9cc5037) Co-authored-by: Carlos Crespo <crespocarlos@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
According to #136912, the test fails when running on cloud, because:
Since there are some tests in the
monitoringtest suite already validating theapm.config.containerattribute and the entire cluster, we could keep this test by changing the assertion to validate only what's necessaryFixes: #137739