Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Fixes the position of popover when presenting dynamic content #139079

Merged
merged 3 commits into from
Aug 25, 2022
Merged

[Security Solution] Fixes the position of popover when presenting dynamic content #139079

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5b29de
Reposition hover action popover when content changes
logeekal Aug 18, 2022
add72f8
added comment
logeekal Aug 18, 2022
9fae0ef
Merge branch 'main' into fix/popover_position_dynamic_content
logeekal Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion x-pack/plugins/security_solution/public/common/components/with_hover_actions/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
HOVER_ACTIONS_ALWAYS_SHOW_CLASS_NAME,
IS_DRAGGING_CLASS_NAME,
} from '@kbn/securitysolution-t-grid';
import React, { useCallback, useEffect, useMemo, useState } from 'react';
import React, { useCallback, useEffect, useMemo, useRef, useState } from 'react';
import styled from 'styled-components';

/**
Expand Down Expand Up @@ -82,6 +82,7 @@ export const WithHoverActions = React.memo<Props>(
const [isOpen, setIsOpen] = useState(hoverContent != null && alwaysShow);
const [showHoverContent, setShowHoverContent] = useState(false);
const [, setHoverTimeout] = useState<number | undefined>(undefined);
const popoverRef = useRef<EuiPopover>(null);

const tryClosePopover = useCallback(() => {
setHoverTimeout((prevHoverTimeout) => {
Expand Down Expand Up @@ -143,12 +144,19 @@ export const WithHoverActions = React.memo<Props>(
setShowHoverContent(false);
}, [closePopOverTrigger]); // NOTE: the `closePopOverTrigger` dependency here will close the hover menu whenever `closePopOverTrigger` changes

useEffect(() => {
// in case of dynamic content i.e when the value of hoverContent changes,
// we will try to reposition the popover so that the content does not collide with screen edge.
if (isOpen) popoverRef?.current?.positionPopoverFluid();
}, [hoverContent, isOpen]);

return (
<div
className={alwaysShow ? HOVER_ACTIONS_ALWAYS_SHOW_CLASS_NAME : ''}
onMouseLeave={onMouseLeave}
>
<WithHoverActionsPopover
ref={popoverRef}
anchorPosition={'downCenter'}
button={content}
closePopover={tryClosePopover}
Expand Down