-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Response Ops] [Alerting] Change triggers_actions_ui
routes to internal
#141149
[Response Ops] [Alerting] Change triggers_actions_ui
routes to internal
#141149
Conversation
triggers_actions_ui
routes to internal
Pinging @elastic/response-ops (Team:ResponseOps) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @ymao1 |
* main: (33 commits) Fix Next and Previous button on step screenshot carousel. (elastic#141422) [journeys] add a short delay after loading data (elastic#141437) skip failing test suite (elastic#140797) skip failing test suite (elastic#138776) Documents saved objects bulk delete API (elastic#141164) [Response Ops][Alerting] Defining default action params on connector type (elastic#141226) [ML] Explain Log Rate Spikes: Adds jest tests for query_utils/buildBaseFilterCriteria. (elastic#141213) [APM] Fix search bar suggestions (elastic#141101) close popover on click (elastic#141272) [Fleet] Update to use savedObjects bulkDelete for package policy delete (elastic#141276) [Security Solution][Endpoint][Response Actions] Do fuzzy search on given usernames for Actions Log (elastic#141239) [Graph] Fix guidance panel appearing for a moment when saving Graph (elastic#141228) [Fleet] Add experimental data stream features support to simplified package policy API (elastic#141288) Shameless copy of the retryTransientEsErrors from fleet (elastic#141246) [Security Solution][Fix]-Issue with disabled dataProvider (elastic#140735) Changing triggers actions ui routes to internal (elastic#141149) skip flaky test suit elastic#141356 [SharedUX] Removing TODOs from KibanaPageTemplate (elastic#141043) [dashboard controls] skip failing test on cloud (elastic#141291) [Synthetics] unskip edit_monitor api integration tests (elastic#141277) ...
Summary
While working on another issue, I noticed that all the
triggers_actions_ui
routes were prefixed with/api
. Since these are all internal facing routes, we should be using/internal
so that we can make changes as necessary.