[Graph] Fix guidance panel appearing for a moment when saving Graph

[davismcphee]

Summary

This PR fixes an issue where the Graph workspace becomes temporarily uninitialized when saving a copy of an existing workspace due to deleting the savedWorkspace.id in these lines in saved_workspace_utils:

kibana/x-pack/plugins/graph/public/helpers/saved_workspace_utils.ts

Lines 165 to 175 in ee4b451

	// Save the original id in case the save fails.
	const originalId = savedObject.id;
	// Read https://github.com/elastic/kibana/issues/9056 and
	// https://github.com/elastic/kibana/issues/9012 for some background into why this copyOnSave variable
	// exists.
	// The goal is to move towards a better rename flow, but since our users have been conditioned
	// to expect a 'save as' flow during a rename, we are keeping the logic the same until a better
	// UI/UX can be worked out.
	if (savedObject.copyOnSave) {
	delete savedObject.id;
	}

The issue is usually hidden since savedWorkspace is a ref, so normally no renders are triggered when it's modified, but the graph calls setRenderCounter in workspace_route on each frame while initializing which triggers a bunch of renders and reveals the bug (add console.log('renderCounter', renderCounter); to workspace_route to see).

Resolves #110238.

Checklist

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
• Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
• If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
• This was checked for cross-browser compatibility

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-graph (Feature:Graph)

[elasticmachine]

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 31aa447

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
graph	450.3KB	450.3KB	+12.0B

History

• 💚 Build #74417 succeeded e6cc955

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @davismcphee

[kertal]

Code LGTM 👍 , tested locally, and the guidance panel was no longer flickering when saving as new. Hope it's not sad. But we're not 😄 ! Thank you, nice fix!

[kibanamachine]

💚 All backports created successfully

Status	Branch	Result
✅	8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

[davismcphee]

💚 All backports created successfully

Status	Branch	Result
✅	8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation