Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Add functional tests for Index data visualizer's random sampler controls #142278

Merged
merged 9 commits into from
Oct 17, 2022

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Sep 29, 2022

Summary

This PR adds functional tests for Data visualizer's random sampler controls. It ensures that settings are retained when navigating to different index patterns/saved searches.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@qn895 qn895 added :ml test_ui_functional release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.5.0 v8.6.0 labels Sep 29, 2022
@qn895 qn895 self-assigned this Sep 29, 2022
@qn895 qn895 requested a review from a team as a code owner September 29, 2022 21:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@qn895 qn895 mentioned this pull request Sep 29, 2022
19 tasks
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, left a few comments.

Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM (with maybe required stability fixes).
Approving now as I'll be on vacation next week, but it'll be good to check this with the flaky runner before merging.

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qn895
Copy link
Member Author

qn895 commented Sep 30, 2022

Running flaky test suite runner...

@darnautov
Copy link
Contributor

@elasticmachine merge upstream

@qn895 qn895 removed the v8.5.0 label Oct 4, 2022
@qn895
Copy link
Member Author

qn895 commented Oct 10, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer 571.3KB 571.6KB +400.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

@qn895
Copy link
Member Author

qn895 commented Oct 17, 2022

Flaky test suite runner successful after 50 runs ✅

@qn895 qn895 merged commit 36f330e into elastic:main Oct 17, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 17, 2022
…controls (elastic#142278)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 36f330e)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@qn895 qn895 removed the backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) label Oct 17, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants