-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Functional tests - stabilize and re-enable test suites #144784
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking test stability in a flaky test runner job ... no ML failure in 50 runs ✔️ |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
pheyos
added
:ml
test_ui_functional
release_note:skip
Skip the PR/issue when compiling release notes
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
v8.6.0
v8.5.1
labels
Nov 8, 2022
Pinging @elastic/ml-ui (:ml) |
qn895
approved these changes
Nov 9, 2022
LGTM 🎉 |
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
pheyos
removed
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
v8.5.1
labels
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
:ml
release_note:skip
Skip the PR/issue when compiling release notes
test_ui_functional
v8.6.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR stabilizes and re-enables a few ML functional test suites.
Details
Re-enable pages test suite
Test ran into a blank page with
[SEVERE] http://localhost:5620/57029/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js 398:83112 TypeError: Reduce of empty array with no initial value
. Seems to be resolved now.Closes #142397
Stabilize and re-enable lens-to-ml test suites
There was an issue with test cleanups, which could bring up confusing failure messages in follow-up tests. The stability fix is to move the job deletion to an
after
method. The root cause of the issue seems to be resolved already.Closes #144186
Closes #142762
Stabilize and re-enable index data visualizer test suite
With the introduction of random sampler in the data visualizer, the total document count was sometimes not the accurate value. The stability fix is to disable random sampling for this assertion by default.
Closes #143007
Stabilize and re-enable custom URL test suite
After navigating to Discover, the test sometimes failed to close the Discover side bar when clicking it too early after navigating to the page. The stability fix is to wait for global loading to finish before closing the side bar.
Closes #143933