Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Attach ML Inference Pipeline - Pipeline re-use #143979

Merged
merged 5 commits into from
Oct 27, 2022
Merged

[Enterprise Search] Attach ML Inference Pipeline - Pipeline re-use #143979

merged 5 commits into from
Oct 27, 2022

Conversation

TattdCodeMonkey
Copy link
Contributor

@TattdCodeMonkey TattdCodeMonkey commented Oct 25, 2022 •
edited
Loading

Summary

Updates the Add Inference Pipeline modal to allow choosing an existing ml-inference- pipeline to attach instead of creating a new pipeline.

  • You can only select pipelines that use a source field that is found on the current index.
  • You cannot add the same pipeline twice.
  • You currently cannot use a pipeline with a trained model that is unavailable to yo. But this will be addressed in follow-up work.

Screenshots

image

image

Pipeline with redacted trained model

image

Pipeline already attached:

image

Checklist

@TattdCodeMonkey TattdCodeMonkey added backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes Team:EnterpriseSearch v8.6.0 labels Oct 25, 2022
@TattdCodeMonkey
Copy link
Contributor Author

cc: @tsclausing @johnbarrierwilson @daveyholler

The option layout is my rough first pass but I'm looking for some opinions/suggestions there as I don't really love it.

@TattdCodeMonkey TattdCodeMonkey force-pushed the rnorris/es/ml-inference-processor-reuse branch from 2b743df to df9156d Compare October 25, 2022 18:37
@TattdCodeMonkey TattdCodeMonkey force-pushed the rnorris/es/ml-inference-processor-reuse branch 2 times, most recently from 552ce6e to de65f38 Compare October 26, 2022 17:02
@TattdCodeMonkey
attach existing ml inference pipeline
f8e18e3 
Added the ability to choose an existing ml inference pipeline and attach
it to the index. This will re-use the existing pipeline instead of
creating a new one.
@TattdCodeMonkey TattdCodeMonkey force-pushed the rnorris/es/ml-inference-processor-reuse branch from de65f38 to f8e18e3 Compare October 26, 2022 19:18
@TattdCodeMonkey TattdCodeMonkey marked this pull request as ready for review October 26, 2022 20:31
@TattdCodeMonkey TattdCodeMonkey requested a review from a team October 26, 2022 20:31
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 1743 1746 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.7MB 1.7MB +7.9KB

History

  • 💔 Build #82923 failed de65f380ac7173fb83822a90fb1e54db159624b4
  • 💔 Build #82910 failed 552ce6e5a61f74a588dffc7a5558442997d55705
  • 💔 Build #82609 failed df9156d05bb447940dec86bb8e21d4a0bb14966d
  • 💔 Build #82603 failed 2b743df1eb9951bde139d4cb07611724210a0543

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

efegurkan
efegurkan approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@efegurkan efegurkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. A lot of cleanup and nice addition of tests.

@TattdCodeMonkey TattdCodeMonkey merged commit 756916d into elastic:main Oct 27, 2022
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 27, 2022
@jloleysens
Merge branch 'main' into files-move-to-src
1b2d913 
* main: (24 commits)
  [Files] Add file upload to file picker (elastic#143969)
  [Security solution] Guided onboarding, alerts & cases (elastic#143598)
  [APM] Critical path for a single trace (elastic#143735)
  skip failing test suite (elastic#143933)
  [Fleet] Update GH Projects automation (elastic#144123)
  [APM] Performance fix for 'cardinality' telemetry task (elastic#144061)
  [Enterprise Search] Attach ML Inference Pipeline - Pipeline re-use (elastic#143979)
  [8.5][DOCS] Add support for differential logs (elastic#143242)
  Bump nwsapi from v2.2.0 to v2.2.2 (elastic#144001)
  [APM] Add waterfall to dependency operations (elastic#143257)
  [Shared UX] Add deprecation message to kibana react Markdown (elastic#143766)
  [Security Solution][Endpoint] Adds RBAC API checks for Blocklist (elastic#144047)
  Improve `needs-team` auto labeling regex (elastic#143787)
  [Reporting/CSV Export] _id field can not be formatted (elastic#143807)
  Adds SavedObjectsWarning to analytics results pages. (elastic#144109)
  Bump chromedriver to 107 (elastic#144073)
  Update cypress (elastic#143755)
  [Maps] nest security layers in layer group (elastic#144055)
  [Lens][Agg based Heatmap] Navigate to Lens Agg based Heatmap. (elastic#143820)
  Added support of saved search (elastic#144095)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efegurkan efegurkan efegurkan approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes Team:EnterpriseSearch v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TattdCodeMonkey @kibana-ci @efegurkan