Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens][Agg based visualizations] Add support convert to lens for visualizations based on saved searches #144095

Merged
merged 1 commit into from
Oct 27, 2022
Merged

[Lens][Agg based visualizations] Add support convert to lens for visualizations based on saved searches #144095

merged 1 commit into from
Oct 27, 2022

Conversation

VladLasitsa
Copy link
Contributor

Summary

Closes: #144084

Agg based visualizations can be created based on saved searches. To convert these visualizations we should allow the transition by unlinking the saved search and go to lens with the applied filters/query.

Visualize.Library.-.Elastic.webm

@VladLasitsa VladLasitsa self-assigned this Oct 27, 2022
@VladLasitsa VladLasitsa added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens backport:skip This commit does not require backporting v8.6.0 labels Oct 27, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visualizations 268.2KB 268.4KB +217.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @VladLasitsa

@VladLasitsa VladLasitsa marked this pull request as ready for review October 27, 2022 13:37
@VladLasitsa VladLasitsa requested a review from a team as a code owner October 27, 2022 13:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@VladLasitsa VladLasitsa requested a review from dej611 October 27, 2022 13:38
dej611
dej611 requested changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one issue when merging queries from saved search and the current context: only the saved search one is carried over, ignoring the current context:

query_not_carried

To test it I've also created a saved search with filters only and when transitioning to Lens no query is shown:

query_not_carried_2

@VladLasitsa
Copy link
Contributor Author

VladLasitsa commented Oct 27, 2022 •
edited
Loading

Found one issue when merging queries from saved search and the current context: only the saved search one is carried over, ignoring the current context:

query_not_carried query_not_carried

To test it I've also created a saved search with filters only and when transitioning to Lens no query is shown:

query_not_carried_2 query_not_carried_2

@dej611 This how works unlink saved search option in agg based visualization, if you unlink saved search on visualization you will see the same.

dej611
dej611 approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline with @VladLasitsa and found out all issues found are actually relative to how Saved Searches work (also when there are no queries in the Saved Search, still clears out the current one).
So no other issues found here 👍

@VladLasitsa VladLasitsa merged commit cb306df into elastic:main Oct 27, 2022
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 27, 2022
@jloleysens
Merge branch 'main' into files-move-to-src
1b2d913 
* main: (24 commits)
  [Files] Add file upload to file picker (elastic#143969)
  [Security solution] Guided onboarding, alerts & cases (elastic#143598)
  [APM] Critical path for a single trace (elastic#143735)
  skip failing test suite (elastic#143933)
  [Fleet] Update GH Projects automation (elastic#144123)
  [APM] Performance fix for 'cardinality' telemetry task (elastic#144061)
  [Enterprise Search] Attach ML Inference Pipeline - Pipeline re-use (elastic#143979)
  [8.5][DOCS] Add support for differential logs (elastic#143242)
  Bump nwsapi from v2.2.0 to v2.2.2 (elastic#144001)
  [APM] Add waterfall to dependency operations (elastic#143257)
  [Shared UX] Add deprecation message to kibana react Markdown (elastic#143766)
  [Security Solution][Endpoint] Adds RBAC API checks for Blocklist (elastic#144047)
  Improve `needs-team` auto labeling regex (elastic#143787)
  [Reporting/CSV Export] _id field can not be formatted (elastic#143807)
  Adds SavedObjectsWarning to analytics results pages. (elastic#144109)
  Bump chromedriver to 107 (elastic#144073)
  Update cypress (elastic#143755)
  [Maps] nest security layers in layer group (elastic#144055)
  [Lens][Agg based Heatmap] Navigate to Lens Agg based Heatmap. (elastic#143820)
  Added support of saved search (elastic#144095)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dej611 dej611 dej611 approved these changes

Assignees

@VladLasitsa VladLasitsa

Labels
backport:skip This commit does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens][Agg based visualizations] Add support convert to lens for visualizations based on saved searches
4 participants
@VladLasitsa @kibana-ci @elasticmachine @dej611