Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Posture] track application views #144665

Merged
merged 4 commits into from
Nov 7, 2022
Merged

[Cloud Posture] track application views #144665

merged 4 commits into from
Nov 7, 2022

Conversation

orouz
Copy link
Contributor

@orouz orouz commented Nov 6, 2022

Summary

the usage_collection plugin has a component (TrackApplicationView) that is used to wrap views and get metrics on their usage, like clicks/time on page.

in addition to already tracking all our views under cloud_security_posture (all routes combined),
we now track all routes defined in cloudPosturePages by their id:

  • cloud_security_posture-findings
  • cloud_security_posture-benchmarks
  • cloud_security_posture-dashboard
  • cloud_security_posture-rules

the tracking is under securitySolutionUI, as we don't register an app anymore, just render routes in security_solution

@orouz orouz added the ci:cloud-redeploy Always create a new Cloud deployment label Nov 6, 2022
@orouz orouz marked this pull request as ready for review November 6, 2022 13:55
@orouz orouz requested a review from a team as a code owner November 6, 2022 13:55
@orouz orouz requested a review from CohenIdo November 6, 2022 13:58
@CohenIdo CohenIdo added release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related labels Nov 6, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security Posture)

@kibana-ci
Copy link
Collaborator

kibana-ci commented Nov 7, 2022

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #1 / Alert Flyout Opens a new timeline investigation with alert ids from the process ancestry
  • [job] [logs] Security Solution Tests #1 / Alerts timeline Privileges: read only "before each" hook for "should not allow user with read only privileges to attach alerts to existing cases"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 124.8KB 124.8KB +64.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cloudSecurityPosture 10.8KB 10.9KB +145.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 58 64 +6
osquery 108 113 +5
securitySolution 440 446 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 66 72 +6
osquery 109 115 +6
securitySolution 517 523 +6
total +20

History

  • 💔 Build #85657 failed 261d8637c9b4b6abb47524efde6846dc8c41b187
  • 💔 Build #85655 failed 23d087713b7eb8220b56a5bdaf0c9a343caba784
  • 💚 Build #85653 succeeded 24cb1424ef5f54c087f5982b71ab1e6c6e380bb3
  • 💚 Build #85650 succeeded 231a83557040a721bbe4ce530d72f52782e168e8

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@orouz orouz requested a review from ari-aviran November 7, 2022 11:31
@orouz orouz merged commit abf0d0f into elastic:main Nov 7, 2022
@kibanamachine kibanamachine added v8.6.0 backport:skip This commit does not require backporting labels Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:cloud-redeploy Always create a new Cloud deployment release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants