[Cloud Posture] track findings pages #144822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orouz
added
release_note:skip
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security Posture) |
orouz
commented
Nov 8, 2022
Comment on lines
+54
to
+56
| <TrackApplicationView viewId={findingsNavigation.findings_by_resource.id}> | ||
| <LatestFindingsByResource dataView={dataView} /> | ||
| </TrackApplicationView> |
There was a problem hiding this comment.
we could remove the inner routes, and combine findingsNavigation with cloudPosturePages, like we did for benchmarks/rules.
this way we could remove the above code and the initial root-routes wrapper would work.
not critical for now imo tho
…-ref HEAD~1..HEAD --fix'
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
CohenIdo
approved these changes
Nov 9, 2022
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 9, 2022
* main: [Lens] Rearrange options (elastic#144891) [Actionable Observability] Integrate alert search bar on rule details page (elastic#144718) [Security Solution] [Exceptions] Adds options to create a shared exception list and to create a single item from the manage exceptions view (elastic#144575) [Actionable Observability] Add context.alertDetailsUrl to connector template for Uptime > Monitor status & Uptime TLS rules (elastic#144740) [Security Solution] [Feat] Add Bulk Events to Timeline. (elastic#142737) [TIP] Env specific cypress config (elastic#144894) skip flaky suite (elastic#144885) [Enterprise Search] Fixes Search Index page to go blank when connection lost (elastic#144022) [Cloud Posture] track findings pages (elastic#144822) [ContentManagement] Inspector flyout (elastic#144240) [Cloud Posture] Dashboard Redesign - data counter cards (elastic#144565) [TIP] Run e2e pipeline on CI (elastic#144776) [Guided onboarding] Config updates for the Security guide (elastic#144844) Cleanup unused code for claiming tasks by id (elastic#144408) Ping the response-ops team whenever a new connector type is registered (elastic#144736)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in #144665 we wrapped all our root routes
the findings page has inner routes, which were wrapped too in this PR with
TrackApplicationView:cloud_security_posture-findings-defaultcloud_security_posture-findings-resourcecloud_security_posture-findings-resourceId