Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profiling: fix setup page and instructions #150885

Merged
merged 6 commits into from
Feb 15, 2023
Merged

profiling: fix setup page and instructions #150885

merged 6 commits into from
Feb 15, 2023

Conversation

inge4pres
Copy link
Contributor

@inge4pres inge4pres commented Feb 10, 2023 •
edited by kibanamachine
Loading

Signed-off-by: inge4pres francesco.gualazzi@elastic.co

Summary

Resolves https://github.com/elastic/prodfiler/issues/2961.
We update the setup information text instructions to add data for Universal Profiling Beta.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

Please test in Cloud using the build from CI.

@inge4pres inge4pres added ci:build-cloud-image ci:cloud-deploy Create or update a Cloud deployment ci:cloud-redeploy Always create a new Cloud deployment labels Feb 10, 2023
@inge4pres inge4pres self-assigned this Feb 10, 2023
@inge4pres inge4pres requested a review from a team as a code owner February 10, 2023 13:59
@inge4pres inge4pres added release_note:skip Skip the PR/issue when compiling release notes backport 8.7 candidate and removed backport labels Feb 10, 2023
@inge4pres inge4pres force-pushed the profiling/update-onboarding-instructions branch from 1627148 to 6801ad9 Compare February 10, 2023 14:02
@inge4pres inge4pres force-pushed the profiling/update-onboarding-instructions branch from 6801ad9 to 69d9620 Compare February 10, 2023 14:27
rockdaboot
rockdaboot reviewed Feb 10, 2023
View reviewed changes
x-pack/plugins/profiling/public/components/no_data_page.tsx
@@ -124,7 +124,8 @@ docker.elastic.co/observability/profiling-agent:stable /root/pf-host-agent \\
}),
content: (
<EuiCodeBlock paddingSize="s" isCopyable>
wget -O- https://releases.prodfiler.com/stable/pf-host-agent_linux_amd64.tgz | tar xz
wget -O pf-host-agent.tgz &quot;https://ela.st/pf-host-agent-amd64&quot; && tar xzf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why you changed this ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been requested in https://github.com/elastic/prodfiler/issues/2961#issue-1574328032

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, it has been requested without giving a reason. Would be interesting to know. Maybe some OSX or zsh incompatibility ? Do you remember or can you find out ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there's a misunderstanding here 😄
The major change here is the use of a different URL, a redirect.
The redirect URL does not have a file extension, so the downloaded file piped into tar would fail.
Aside from the URL, we mainly changed the wget option to download to a file instead of STDOUT.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you pipe the wget output to tar, you don't need any file extension.
Just try it out yourself:

wget -O- https://ela.st/pf-host-agent-amd64 | tar xz

works like a charm without having to store an intermediate file.

@rockdaboot
Copy link
Contributor

Can you add two screenshots (before / after) ? I am not sure where to look at atm (running Kibana with your branch locally).

@inge4pres inge4pres force-pushed the profiling/update-onboarding-instructions branch from 69d9620 to b8d53a6 Compare February 10, 2023 14:56
@inge4pres inge4pres mentioned this pull request Feb 10, 2023
Closed
@inge4pres inge4pres force-pushed the profiling/update-onboarding-instructions branch from b8d53a6 to a454f40 Compare February 10, 2023 16:46
@boriskirov
Copy link
Contributor

Just posting the latest updates in this PR

Before / After
image

@inge4pres inge4pres force-pushed the profiling/update-onboarding-instructions branch 5 times, most recently from 810dec9 to c351b81 Compare February 13, 2023 16:07
rockdaboot
rockdaboot approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@rockdaboot rockdaboot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@inge4pres
profiling: fix setup page and instructions
1bf05ff 
Signed-off-by: inge4pres <francesco.gualazzi@elastic.co>
@inge4pres inge4pres force-pushed the profiling/update-onboarding-instructions branch from 6d63aa1 to 0d8a649 Compare February 14, 2023 08:57
@kibana-ci
Copy link
Collaborator

kibana-ci commented Feb 15, 2023 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
profiling 257.0KB 258.2KB +1.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @inge4pres

@inge4pres inge4pres merged commit 560c3b9 into elastic:main Feb 15, 2023
@kibanamachine kibanamachine mentioned this pull request Feb 15, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 15, 2023
@inge4pres
profiling: fix setup page and instructions (elastic#150885)
064705f 
Resolves elastic/prodfiler#2961.
We update the setup information text instructions to add data for
Universal Profiling Beta.

Signed-off-by: inge4pres <francesco.gualazzi@elastic.co>
Co-authored-by: boriskirov <boris.kirov@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 560c3b9)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@inge4pres inge4pres deleted the profiling/update-onboarding-instructions branch February 15, 2023 10:55
kibanamachine added a commit that referenced this pull request Feb 15, 2023
@kibanamachine @inge4pres
[8.7] profiling: fix setup page and instructions (#150885) (#151266)
c88403c 
# Backport

This will backport the following commits from `main` to `8.7`:
- [profiling: fix setup page and instructions
(#150885)](#150885)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Francesco
Gualazzi","email":"inge4pres@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-02-15T10:50:29Z","message":"profiling:
fix setup page and instructions (#150885)\n\nResolves
elastic/prodfiler#2961 update the setup
information text instructions to add data for\r\nUniversal Profiling
Beta.\r\n\r\n\r\nSigned-off-by: inge4pres
<francesco.gualazzi@elastic.co>\r\nCo-authored-by: boriskirov
<boris.kirov@elastic.co>\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"560c3b96f81ce2167a3d104bf97e4fe5a1e7fb76","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","8.7
candidate","ci:build-cloud-image","ci:cloud-deploy","ci:cloud-redeploy","v8.7.0","v8.8.0"],"number":150885,"url":"#150885:
fix setup page and instructions (#150885)\n\nResolves
elastic/prodfiler#2961 update the setup
information text instructions to add data for\r\nUniversal Profiling
Beta.\r\n\r\n\r\nSigned-off-by: inge4pres
<francesco.gualazzi@elastic.co>\r\nCo-authored-by: boriskirov
<boris.kirov@elastic.co>\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"560c3b96f81ce2167a3d104bf97e4fe5a1e7fb76"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"#150885:
fix setup page and instructions (#150885)\n\nResolves
elastic/prodfiler#2961 update the setup
information text instructions to add data for\r\nUniversal Profiling
Beta.\r\n\r\n\r\nSigned-off-by: inge4pres
<francesco.gualazzi@elastic.co>\r\nCo-authored-by: boriskirov
<boris.kirov@elastic.co>\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"560c3b96f81ce2167a3d104bf97e4fe5a1e7fb76"}}]}]
BACKPORT-->

Co-authored-by: Francesco Gualazzi <inge4pres@users.noreply.github.com>
justinkambic pushed a commit to justinkambic/kibana that referenced this pull request Feb 23, 2023
@inge4pres @boriskirov
@kibanamachine @justinkambic
profiling: fix setup page and instructions (elastic#150885)
289eacb 
Resolves elastic/prodfiler#2961.
We update the setup information text instructions to add data for
Universal Profiling Beta.


Signed-off-by: inge4pres <francesco.gualazzi@elastic.co>
Co-authored-by: boriskirov <boris.kirov@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@inge4pres inge4pres mentioned this pull request Apr 27, 2023
Merged
3 tasks
jbcrail pushed a commit that referenced this pull request May 2, 2023
@inge4pres @kibanamachine @jen-huang
Profiling: symbolization created on user opt-in (#156089)
d4f6cf7 
Signed-off-by: inge4pres <francesco.gualazzi@elastic.co>

## Summary

Include the creation of symbolizer package policy in the setup initiated
by users when they opt-in Universal Profiling.

### Checklist

- [X]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Related issues or PRs
* #155642
* #150885

---------

Signed-off-by: inge4pres <francesco.gualazzi@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Jen Huang <its.jenetic@gmail.com>
kibanamachine pushed a commit that referenced this pull request May 2, 2023
@inge4pres
Profiling: symbolization created on user opt-in (#156089)
e3fffe2 
Signed-off-by: inge4pres <francesco.gualazzi@elastic.co>

## Summary

Include the creation of symbolizer package policy in the setup initiated
by users when they opt-in Universal Profiling.

### Checklist

- [X]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Related issues or PRs
* #155642
* #150885

---------

Signed-off-by: inge4pres <francesco.gualazzi@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Jen Huang <its.jenetic@gmail.com>
(cherry picked from commit d4f6cf7)
kibanamachine added a commit that referenced this pull request May 2, 2023
@kibanamachine @inge4pres
[8.8] Profiling: symbolization created on user opt-in (#156089) (#156449
4782455 
)

# Backport

This will backport the following commits from `main` to `8.8`:
- [Profiling: symbolization created on user opt-in
(#156089)](#156089)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Francesco
Gualazzi","email":"inge4pres@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-02T18:24:54Z","message":"Profiling:
symbolization created on user opt-in (#156089)\n\nSigned-off-by:
inge4pres <francesco.gualazzi@elastic.co>\r\n\r\n##
Summary\r\n\r\nInclude the creation of symbolizer package policy in the
setup initiated\r\nby users when they opt-in Universal
Profiling.\r\n\r\n### Checklist\r\n\r\n-
[X]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [X] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n### For
maintainers\r\n\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n###
Related issues or PRs\r\n*
#155642
#150885:
inge4pres <francesco.gualazzi@elastic.co>\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Jen
Huang
<its.jenetic@gmail.com>","sha":"d4f6cf703da8022aeedfabca6ff7689faf67e071","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","auto-backport","ci:build-cloud-image","8.8
candidate","v8.8.0","v8.9.0"],"number":156089,"url":"#156089:
symbolization created on user opt-in (#156089)\n\nSigned-off-by:
inge4pres <francesco.gualazzi@elastic.co>\r\n\r\n##
Summary\r\n\r\nInclude the creation of symbolizer package policy in the
setup initiated\r\nby users when they opt-in Universal
Profiling.\r\n\r\n### Checklist\r\n\r\n-
[X]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [X] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n### For
maintainers\r\n\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n###
Related issues or PRs\r\n*
#155642
#150885:
inge4pres <francesco.gualazzi@elastic.co>\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Jen
Huang
<its.jenetic@gmail.com>","sha":"d4f6cf703da8022aeedfabca6ff7689faf67e071"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"#156089:
symbolization created on user opt-in (#156089)\n\nSigned-off-by:
inge4pres <francesco.gualazzi@elastic.co>\r\n\r\n##
Summary\r\n\r\nInclude the creation of symbolizer package policy in the
setup initiated\r\nby users when they opt-in Universal
Profiling.\r\n\r\n### Checklist\r\n\r\n-
[X]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [X] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n### For
maintainers\r\n\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n###
Related issues or PRs\r\n*
#155642
#150885:
inge4pres <francesco.gualazzi@elastic.co>\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Jen
Huang
<its.jenetic@gmail.com>","sha":"d4f6cf703da8022aeedfabca6ff7689faf67e071"}}]}]
BACKPORT-->

Co-authored-by: Francesco Gualazzi <inge4pres@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgieselaar dgieselaar dgieselaar left review comments

@rockdaboot rockdaboot rockdaboot approved these changes

@boriskirov boriskirov boriskirov approved these changes

Assignees

@inge4pres inge4pres

Labels
8.7 candidate ci:build-cloud-image ci:cloud-deploy Create or update a Cloud deployment ci:cloud-redeploy Always create a new Cloud deployment release_note:skip Skip the PR/issue when compiling release notes v8.7.0 v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@inge4pres @rockdaboot @boriskirov @kibana-ci @kibanamachine @dgieselaar