Fleet: allow Universal Profiling symbolizer permissions on indices #155642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: inge4pres <francesco.gualazzi@elastic.co>
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
inge4pres
added
the
release_note:skip
nchaulet
reviewed
Apr 24, 2023
| @@ -42,6 +52,12 @@ export async function storedPackagePoliciesToAgentPermissions( | |||
|
|
|||
| const pkg = packageInfoCache.get(pkgToPkgKey(packagePolicy.package))!; | |||
|
|
|||
| // Special handling for Universal Profiling packages, as it does not use data streams _only_, | |||
| // but also indices that do not adhere to the convention. | |||
| if (pkg.name==='profiler_symbolizer') { | |||
There was a problem hiding this comment.
nit: will be great to define a constant for that package here https://github.com/elastic/kibana/blob/main/x-pack/plugins/fleet/common/constants/epm.ts
There was a problem hiding this comment.
Sure! Thanks for the suggestion, will do
…-ref HEAD~1..HEAD --fix'
nchaulet
approved these changes
Apr 24, 2023
Signed-off-by: inge4pres <francesco.gualazzi@elastic.co>
…-ref HEAD~1..HEAD --fix'
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @inge4pres |
kibanamachine
added
v8.8.0
backport:skip
3 tasks
jbcrail
pushed a commit
that referenced
this pull request
May 2, 2023
Signed-off-by: inge4pres <francesco.gualazzi@elastic.co> ## Summary Include the creation of symbolizer package policy in the setup initiated by users when they opt-in Universal Profiling. ### Checklist - [X] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Related issues or PRs * #155642 * #150885 --------- Signed-off-by: inge4pres <francesco.gualazzi@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Jen Huang <its.jenetic@gmail.com>
kibanamachine
pushed a commit
that referenced
this pull request
May 2, 2023
Signed-off-by: inge4pres <francesco.gualazzi@elastic.co> ## Summary Include the creation of symbolizer package policy in the setup initiated by users when they opt-in Universal Profiling. ### Checklist - [X] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Related issues or PRs * #155642 * #150885 --------- Signed-off-by: inge4pres <francesco.gualazzi@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Jen Huang <its.jenetic@gmail.com> (cherry picked from commit d4f6cf7)
kibanamachine
referenced
this pull request
May 2, 2023
) # Backport This will backport the following commits from `main` to `8.8`: - [Profiling: symbolization created on user opt-in (#156089)](#156089) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Francesco Gualazzi","email":"inge4pres@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-02T18:24:54Z","message":"Profiling: symbolization created on user opt-in (#156089)\n\nSigned-off-by: inge4pres <francesco.gualazzi@elastic.co>\r\n\r\n## Summary\r\n\r\nInclude the creation of symbolizer package policy in the setup initiated\r\nby users when they opt-in Universal Profiling.\r\n\r\n### Checklist\r\n\r\n- [X]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n### Related issues or PRs\r\n* https://github.com/elastic/kibana/pull/155642\r\n* https://github.com/elastic/kibana/pull/150885\r\n\r\n---------\r\n\r\nSigned-off-by: inge4pres <francesco.gualazzi@elastic.co>\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Jen Huang <its.jenetic@gmail.com>","sha":"d4f6cf703da8022aeedfabca6ff7689faf67e071","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","auto-backport","ci:build-cloud-image","8.8 candidate","v8.8.0","v8.9.0"],"number":156089,"url":"https://github.com/elastic/kibana/pull/156089","mergeCommit":{"message":"Profiling: symbolization created on user opt-in (#156089)\n\nSigned-off-by: inge4pres <francesco.gualazzi@elastic.co>\r\n\r\n## Summary\r\n\r\nInclude the creation of symbolizer package policy in the setup initiated\r\nby users when they opt-in Universal Profiling.\r\n\r\n### Checklist\r\n\r\n- [X]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n### Related issues or PRs\r\n* https://github.com/elastic/kibana/pull/155642\r\n* https://github.com/elastic/kibana/pull/150885\r\n\r\n---------\r\n\r\nSigned-off-by: inge4pres <francesco.gualazzi@elastic.co>\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Jen Huang <its.jenetic@gmail.com>","sha":"d4f6cf703da8022aeedfabca6ff7689faf67e071"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156089","number":156089,"mergeCommit":{"message":"Profiling: symbolization created on user opt-in (#156089)\n\nSigned-off-by: inge4pres <francesco.gualazzi@elastic.co>\r\n\r\n## Summary\r\n\r\nInclude the creation of symbolizer package policy in the setup initiated\r\nby users when they opt-in Universal Profiling.\r\n\r\n### Checklist\r\n\r\n- [X]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n### Related issues or PRs\r\n* https://github.com/elastic/kibana/pull/155642\r\n* https://github.com/elastic/kibana/pull/150885\r\n\r\n---------\r\n\r\nSigned-off-by: inge4pres <francesco.gualazzi@elastic.co>\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Jen Huang <its.jenetic@gmail.com>","sha":"d4f6cf703da8022aeedfabca6ff7689faf67e071"}}]}] BACKPORT--> Co-authored-by: Francesco Gualazzi <inge4pres@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For the introduction of the Universal Profiling symbolizer in Cloud, Fleet needs an update.
The reason for Universal Profiling symbolizer to be different from other packages running via Fleet is that:
Checklist
Delete any items that are not applicable to this PR.
For maintainers