[Content Management] Cross Type Search - paginate and tags filter #154819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dosant
changed the title
Dosant
added
release_note:skip
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
sebelga
approved these changes
Apr 12, 2023
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.8.0
backport:skip
mattkime
reviewed
Apr 15, 2023
| @@ -8,6 +8,7 @@ | |||
| import { schema } from '@kbn/config-schema'; | |||
| import type { IRouter } from '@kbn/core/server'; | |||
|
|
|||
| import { LISTING_LIMIT_SETTING, PER_PAGE_SETTING } from '@kbn/saved-objects-finder-plugin/common'; | |||
mattkime
reviewed
Apr 15, 2023
| @@ -14,6 +14,7 @@ | |||
| "@kbn/object-versioning", | |||
| "@kbn/core-saved-objects-api-server-mocks", | |||
| "@kbn/core-saved-objects-api-server", | |||
| "@kbn/saved-objects-finder-plugin", | |||
There was a problem hiding this comment.
Unfortunately this causes problems. content_management dependencies need to be minimized.
@kbn/saved-objects-finder-plugin depends upon @kbn/saved-objects-management-plugin depends upon the data and data-view plugins which means its a circular dependency if they then try to implement the CM api.
I guess there are other places in that dependency chain where changes could be made but this seems like a simple place.
Dosant
added a commit
that referenced
this pull request
Apr 17, 2023
…ct_finder (#155013) ## Summary Follow up #154819, @mattkime pointed out a problem that cm can't depend on saved_object_finder https://github.com/elastic/kibana/pull/154819/files#diff-635bc20df585b656afebba3ebf338ff997e735df933f704cc5f253a74b3503ddR17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #154464
Partially resolve #152224 - implement pagination and tags filtering