Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Content Management] Remove dep from content_management -> saved_object_finder #155013

Merged
merged 2 commits into from
Apr 17, 2023
Merged

[Content Management] Remove dep from content_management -> saved_object_finder #155013

merged 2 commits into from
Apr 17, 2023

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Apr 17, 2023 •
edited
Loading

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #17 / machine learning basic license - data visualizer - group 2 index based with farequote KQL saved search displays index details
  • [job] [logs] FTR Configs #17 / machine learning basic license - data visualizer - group 2 index based with farequote lucene saved search displays index details

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
savedObjectsFinder 7 8 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/saved-objects-settings - 2 +2
Unknown metric groups

API count

id before after diff
@kbn/saved-objects-settings - 2 +2

ESLint disabled line counts

id before after diff
securitySolution 432 435 +3

Total ESLint disabled count

id before after diff
securitySolution 512 515 +3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant changed the title remove dep from content_management -> saved_object_finder [Content Management] Remove dep from content_management -> saved_object_finder Apr 17, 2023
@Dosant Dosant added release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) Feature:Content Management User generated content (saved objects) management labels Apr 17, 2023
@Dosant Dosant marked this pull request as ready for review April 17, 2023 12:58
@Dosant Dosant requested review from a team as code owners April 17, 2023 12:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@Dosant Dosant requested review from mattkime and sebelga April 17, 2023 12:58
mattkime
mattkime approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm, thanks for the quick fix

sebelga
sebelga approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@Dosant Dosant merged commit 4edb583 into elastic:main Apr 17, 2023
@kibanamachine kibanamachine added v8.8.0 backport:skip This commit does not require backporting labels Apr 17, 2023
@Dosant Dosant self-assigned this Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebelga sebelga sebelga approved these changes

@mattkime mattkime mattkime approved these changes

Assignees

@Dosant Dosant

Labels
backport:skip This commit does not require backporting Feature:Content Management User generated content (saved objects) management release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Dosant @kibana-ci @elasticmachine @mattkime @sebelga @kibanamachine