Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cases] Separate Cases SO attributes from HTTP APIs #155277

Merged
merged 14 commits into from
Apr 26, 2023
Merged

[Cases] Separate Cases SO attributes from HTTP APIs #155277

merged 14 commits into from
Apr 26, 2023

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented Apr 19, 2023 •
edited
Loading

Summary

This PR changes the types of the Case entity to separate the SO attributes from the HTTP APIs.

Notable changes

  • A new server-side type is created to describe the data persistent into ES through the SO client. It is called CasePersistedAttributes.
  • The type CaseResponse is renamed to Case.
  • The type CasesResponse is renamed to Cases.
  • The type Case is renamed to CaseUI.
  • The type Cases is renamed to CasesUI.

For maintainers

@cnasikas cnasikas changed the base branch from main to cases-split-types-feature April 20, 2023 15:15
@cnasikas cnasikas changed the title [Cases] Separate SO attributes from HTTP APIs [Cases] Separate Cases SO attributes from HTTP APIs Apr 20, 2023
@cnasikas cnasikas self-assigned this Apr 23, 2023
@cnasikas cnasikas added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature labels Apr 23, 2023
@cnasikas cnasikas marked this pull request as ready for review April 24, 2023 12:47
@cnasikas cnasikas requested review from a team as code owners April 24, 2023 12:47
@cnasikas cnasikas requested review from ashokaditya and parkiino and removed request for a team April 24, 2023 12:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Apr 24, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

shahzad31
shahzad31 approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uptime code changes LGTM !!

@cnasikas cnasikas removed request for a team, spong, ashokaditya and parkiino April 26, 2023 08:10
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
cases 79 81 +2

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
cases 32 31 -1
Unknown metric groups

API count

id before after diff
cases 96 98 +2

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 479 482 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

@cnasikas cnasikas merged commit bf588bf into elastic:cases-split-types-feature Apr 26, 2023
@cnasikas cnasikas deleted the http_step_1 branch April 26, 2023 13:02
@jonathan-buttner jonathan-buttner mentioned this pull request Apr 27, 2023
Merged
jonathan-buttner added a commit that referenced this pull request Apr 28, 2023
@jonathan-buttner @cnasikas @patrykkopycinski
[Cases] Separate Cases SO attributes from HTTP APIs (#155898)
6d5e245 
This PR separates the persisted SO attributes from the fields received
in the HTTP API requests.

This is to address step 2 in preparing our HTTP routes as versioned.

Issue: #153726

This PR encompasses a few PRs here which have been reviewed individually
by the cases team members:

#155325 - User actions
#155440 - Attachments
#155444 - Configure, Connector
Mappings
#155277 - Cases

The large number of files is because of renaming some types throughout
the frontend code. There shouldn't be many functionality changes, mostly
just type changes.

---------

Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-buttner jonathan-buttner jonathan-buttner approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@stephmilovic stephmilovic stephmilovic approved these changes

Assignees

@cnasikas cnasikas

Labels
Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cnasikas @elasticmachine @kibana-ci @shahzad31 @stephmilovic @jonathan-buttner