[Cases] Separate Cases SO attributes from HTTP APIs #155898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary This PR changes the types of the Case entity to separate the SO attributes from the HTTP APIs. ### Notable changes - A new server-side type is created to describe the data persistent into ES through the SO client. It is called `CasePersistedAttributes`. - The type `CaseResponse` is renamed to `Case`. - The type `CasesResponse` is renamed to `Cases`. - The type `Case` is renamed to `CaseUI`. - The type `Cases` is renamed to `CasesUI`. ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Jonathan Buttner <jonathan.buttner@elastic.co>
jonathan-buttner
added
release_note:skip
…e layer (#155325) This PR separates the http API io-ts types from the types that are used in the cases service layer to interact with the saved object client. This PR is specifically for the user actions it only affects the types used when interacting with the saved object client and doesn't touch the transformation logic yet. Issue: #153726
This PR separates the http API io-ts types from the types that are used in the cases service layer to interact with the saved object client. This PR is specifically for the attachments it only affects the types used when interacting with the saved object client and doesn't touch the transformation logic yet. Issue: #153726
30 tasks
This PR separates the http API io-ts types from the types that are used in the cases service layer to interact with the saved object client. This PR is splits up the remaining types within the service layer (configure and connector mappings). Issue: #153726
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
kqualters-elastic
approved these changes
Apr 27, 2023
dominiqueclarke
approved these changes
Apr 27, 2023
stephmilovic
approved these changes
Apr 27, 2023
This was referenced Apr 27, 2023
patrykkopycinski
approved these changes
Apr 27, 2023
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Public APIs missing exports
Unknown metric groupsAPI count
ESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
js-jankisalvi
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates the persisted SO attributes from the fields received in the HTTP API requests.
This is to address step 2 in preparing our HTTP routes as versioned.
Issue: #153726
This PR encompasses a few PRs here which have been reviewed individually by the cases team members:
#155325 - User actions
#155440 - Attachments
#155444 - Configure, Connector Mappings
#155277 - Cases
The large number of files is because of renaming some types throughout the frontend code. There shouldn't be many functionality changes, mostly just type changes.