Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Do not re-render embeddable visualizations on detail/history page onLoad #156219

Conversation

justinkambic
Copy link
Contributor

@justinkambic justinkambic commented Apr 28, 2023

Summary

Resolves #155917.

This patch makes it so that our embeddables do not re-render on load. The autorefresh is needlessly destructive to the existing data, and with the high number of embeddables on the page it makes it difficult to track what's changed when the data updates.

This patch keeps the progress bar on load to signify the data will update, but it does not fully re-render the visualizations before rendering the updated data.

Before

20230428151021

After

20230428142124

20230428142237

20230428150204

Testing

Load up the detail view for a monitor and look for any visualization that replaces the viz with a loading spinner before rendering the updated data.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@justinkambic justinkambic added bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes v8.8.0 v8.9.0 labels Apr 28, 2023
@justinkambic justinkambic self-assigned this Apr 28, 2023
@justinkambic justinkambic requested a review from a team as a code owner April 28, 2023 19:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
exploratoryView 60.5KB 60.5KB +22.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 479 482 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @justinkambic

@shahzad31 shahzad31 merged commit 7b94718 into elastic:main May 2, 2023
@shahzad31 shahzad31 deleted the 155197/remove-loading-state-for-silent-update-on-detail-page branch May 2, 2023 06:50
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 2, 2023
…tory page `onLoad` (elastic#156219)

Co-authored-by: shahzad31 <shahzad31comp@gmail.com>
(cherry picked from commit 7b94718)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 2, 2023
…il/history page `onLoad` (#156219) (#156327)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Synthetics] Do not re-render embeddable visualizations on
detail/history page `onLoad`
(#156219)](#156219)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Justin
Kambic","email":"jk@elastic.co"},"sourceCommit":{"committedDate":"2023-05-02T06:50:02Z","message":"[Synthetics]
Do not re-render embeddable visualizations on detail/history page
`onLoad` (#156219)\n\nCo-authored-by: shahzad31
<shahzad31comp@gmail.com>","sha":"7b947188f222a81cc8481c1b34ededfdc4363ff0","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:uptime","release_note:skip","v8.8.0","v8.9.0"],"number":156219,"url":"#156219
Do not re-render embeddable visualizations on detail/history page
`onLoad` (#156219)\n\nCo-authored-by: shahzad31
<shahzad31comp@gmail.com>","sha":"7b947188f222a81cc8481c1b34ededfdc4363ff0"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"#156219
Do not re-render embeddable visualizations on detail/history page
`onLoad` (#156219)\n\nCo-authored-by: shahzad31
<shahzad31comp@gmail.com>","sha":"7b947188f222a81cc8481c1b34ededfdc4363ff0"}}]}]
BACKPORT-->

Co-authored-by: Justin Kambic <jk@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.8.0 v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Synthetics] Auto refresh - Auto refresh should ideally be silent on monitor details and test run details
6 participants