Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Advanced policy options for Endpoint 8.8 #156308

Merged
merged 2 commits into from
May 1, 2023
Merged

[Security Solution] Advanced policy options for Endpoint 8.8 #156308

merged 2 commits into from
May 1, 2023

Conversation

kevinlog
Copy link
Contributor

@kevinlog kevinlog commented May 1, 2023 •
edited by kibanamachine
Loading

Summary

Adds several more advanced options for Endpoint to Policy.

image

Checklist

Delete any items that are not applicable to this PR.

@kevinlog kevinlog added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.8.0 v8.9.0 labels May 1, 2023
@kevinlog kevinlog requested a review from a team as a code owner May 1, 2023 21:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@kevinlog kevinlog enabled auto-merge (squash) May 1, 2023 21:11
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #3 / timeline flyout button the (+) button popover menu owns focus

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.1MB 9.1MB +10.4KB
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 479 482 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kevinlog kevinlog merged commit 47b1ca3 into elastic:main May 1, 2023
@kibanamachine kibanamachine mentioned this pull request May 1, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 1, 2023
@kevinlog
[Security Solution] Advanced policy options for Endpoint 8.8 (elastic…
0bd6afe 
…#156308)

## Summary

Adds several more advanced options for Endpoint to Policy.

![image](https://user-images.githubusercontent.com/56395104/235530865-635a6427-336c-4120-9112-47fb3ea9fe5e.png)

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 47b1ca3)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 2, 2023
@kibanamachine @kevinlog
[8.8] [Security Solution] Advanced policy options for Endpoint 8.8 (#…
edd78ba 
…156308) (#156319)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Security Solution] Advanced policy options for Endpoint 8.8
(#156308)](#156308)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kevin
Logan","email":"56395104+kevinlog@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-01T22:44:35Z","message":"[Security
Solution] Advanced policy options for Endpoint 8.8 (#156308)\n\n##
Summary\r\n\r\nAdds several more advanced options for Endpoint to
Policy.\r\n\r\n\r\n![image](https://user-images.githubusercontent.com/56395104/235530865-635a6427-336c-4120-9112-47fb3ea9fe5e.png)\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"47b1ca38136cacfebf98b4f1fd16fc0e2cdd8ecf","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend
Workflows","v8.8.0","v8.9.0"],"number":156308,"url":"#156308
Solution] Advanced policy options for Endpoint 8.8 (#156308)\n\n##
Summary\r\n\r\nAdds several more advanced options for Endpoint to
Policy.\r\n\r\n\r\n![image](https://user-images.githubusercontent.com/56395104/235530865-635a6427-336c-4120-9112-47fb3ea9fe5e.png)\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"47b1ca38136cacfebf98b4f1fd16fc0e2cdd8ecf"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"#156308
Solution] Advanced policy options for Endpoint 8.8 (#156308)\n\n##
Summary\r\n\r\nAdds several more advanced options for Endpoint to
Policy.\r\n\r\n\r\n![image](https://user-images.githubusercontent.com/56395104/235530865-635a6427-336c-4120-9112-47fb3ea9fe5e.png)\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"47b1ca38136cacfebf98b4f1fd16fc0e2cdd8ecf"}}]}]
BACKPORT-->

Co-authored-by: Kevin Logan <56395104+kevinlog@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeypoon joeypoon joeypoon approved these changes

@nfritts nfritts nfritts approved these changes

@patrykkopycinski patrykkopycinski Awaiting requested review from patrykkopycinski patrykkopycinski is a code owner automatically assigned from elastic/security-defend-workflows

@gergoabraham gergoabraham Awaiting requested review from gergoabraham gergoabraham is a code owner automatically assigned from elastic/security-defend-workflows

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.8.0 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kevinlog @elasticmachine @kibana-ci @kibanamachine @joeypoon @nfritts