Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search] Copyedit: remove redundant link, simplify wording #156391

Merged
merged 2 commits into from
May 2, 2023

Conversation

leemthompo
Copy link
Contributor

@leemthompo leemthompo commented May 2, 2023

Summary

  • Removes redundant link
  • Minor copyedit

I noticed the link to Ruby repo was not removed when the Python link was added.

Before
Screenshot 2023-05-02 at 15 48 13

After
Screenshot 2023-05-02 at 15 55 58

@leemthompo leemthompo added release_note:skip Skip the PR/issue when compiling release notes v8.8.0 labels May 2, 2023
@leemthompo leemthompo self-assigned this May 2, 2023
@leemthompo leemthompo requested a review from a team May 2, 2023 14:04
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@leemthompo leemthompo enabled auto-merge (squash) May 2, 2023 15:01
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.3MB 2.3MB -732.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @leemthompo

@leemthompo leemthompo merged commit 0324cdc into elastic:main May 2, 2023
@leemthompo leemthompo deleted the ent-search-copy branch May 2, 2023 15:41
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 2, 2023
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 2, 2023
…ording (#156391) (#156416)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Enterprise Search] Copyedit: remove redundant link, simplify wording
(#156391)](#156391)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Liam
Thompson","email":"32779855+leemthompo@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-02T15:40:53Z","message":"[Enterprise
Search] Copyedit: remove redundant link, simplify wording
(#156391)","sha":"0324cdcd65b76b9819952ef9395f87c07468ec77","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.8.0","v8.9.0"],"number":156391,"url":"#156391
Search] Copyedit: remove redundant link, simplify wording
(#156391)","sha":"0324cdcd65b76b9819952ef9395f87c07468ec77"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"#156391
Search] Copyedit: remove redundant link, simplify wording
(#156391)","sha":"0324cdcd65b76b9819952ef9395f87c07468ec77"}}]}]
BACKPORT-->

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.8.0 v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants