Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[functional tests] split fleet_api_integration config into smaller ones #156407

Merged

Conversation

dmlemeshko
Copy link
Member

@dmlemeshko dmlemeshko commented May 2, 2023

Summary

Runtime for fleet_api_integration/config crossed the 38 min limit. Ideally config runtime should be <10 min so that pipeline can quickly retry failed configs (we do 1 retry on CI)

image

This PR splits the existing config into few smaller ones:

x-pack/test/fleet_api_integration/config.agent.ts 15m 15s
x-pack/test/fleet_api_integration/config.agent_policy.ts 4m 10s
x-pack/test/fleet_api_integration/config.epm.ts 8m 12s
x-pack/test/fleet_api_integration/config.package_policy.ts 10m 54s
// combines multiple test files
x-pack/test/fleet_api_integration/config.fleet.ts 5m 2s

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dmlemeshko dmlemeshko marked this pull request as ready for review May 3, 2023 09:45
@dmlemeshko dmlemeshko requested review from a team as code owners May 3, 2023 09:45
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label May 3, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@dmlemeshko dmlemeshko added v8.8.0 v8.9.0 v8.7.2 release_note:skip Skip the PR/issue when compiling release notes labels May 3, 2023
@dmlemeshko dmlemeshko merged commit 1c777a2 into elastic:main May 3, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 3, 2023
…es (elastic#156407)

## Summary

Runtime for `fleet_api_integration/config` crossed the 38 min limit.
Ideally config runtime should be <10 min so that pipeline can quickly
retry failed configs (we do 1 retry on CI)

<img width="1600" alt="image"
src="https://user-images.githubusercontent.com/10977896/235707744-3120e1e9-4882-493f-9ee0-86016a765401.png">

This PR splits the existing config into few smaller ones:

```
x-pack/test/fleet_api_integration/config.agent.ts 15m 15s
x-pack/test/fleet_api_integration/config.agent_policy.ts 4m 10s
x-pack/test/fleet_api_integration/config.epm.ts 8m 12s
x-pack/test/fleet_api_integration/config.package_policy.ts 10m 54s
// combines multiple test files
x-pack/test/fleet_api_integration/config.fleet.ts 5m 2s
```

(cherry picked from commit 1c777a2)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.7 Backport failed because of merge conflicts
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 156407

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 3, 2023
…ler ones (#156407) (#156559)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[functional tests] split fleet_api_integration config into smaller
ones (#156407)](#156407)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dzmitry
Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2023-05-03T14:26:58Z","message":"[functional
tests] split fleet_api_integration config into smaller ones
(#156407)\n\n## Summary\r\n\r\nRuntime for
`fleet_api_integration/config` crossed the 38 min limit.\r\nIdeally
config runtime should be <10 min so that pipeline can quickly\r\nretry
failed configs (we do 1 retry on CI)\r\n\r\n<img width=\"1600\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/10977896/235707744-3120e1e9-4882-493f-9ee0-86016a765401.png\">\r\n\r\n\r\nThis
PR splits the existing config into few smaller
ones:\r\n\r\n```\r\nx-pack/test/fleet_api_integration/config.agent.ts
15m 15s\r\nx-pack/test/fleet_api_integration/config.agent_policy.ts 4m
10s\r\nx-pack/test/fleet_api_integration/config.epm.ts 8m
12s\r\nx-pack/test/fleet_api_integration/config.package_policy.ts 10m
54s\r\n// combines multiple test
files\r\nx-pack/test/fleet_api_integration/config.fleet.ts 5m
2s\r\n```","sha":"1c777a2e702f7c5ae9c1b86063515c0a27368efb","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v8.8.0","v8.7.2","v8.9.0"],"number":156407,"url":"#156407
tests] split fleet_api_integration config into smaller ones
(#156407)\n\n## Summary\r\n\r\nRuntime for
`fleet_api_integration/config` crossed the 38 min limit.\r\nIdeally
config runtime should be <10 min so that pipeline can quickly\r\nretry
failed configs (we do 1 retry on CI)\r\n\r\n<img width=\"1600\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/10977896/235707744-3120e1e9-4882-493f-9ee0-86016a765401.png\">\r\n\r\n\r\nThis
PR splits the existing config into few smaller
ones:\r\n\r\n```\r\nx-pack/test/fleet_api_integration/config.agent.ts
15m 15s\r\nx-pack/test/fleet_api_integration/config.agent_policy.ts 4m
10s\r\nx-pack/test/fleet_api_integration/config.epm.ts 8m
12s\r\nx-pack/test/fleet_api_integration/config.package_policy.ts 10m
54s\r\n// combines multiple test
files\r\nx-pack/test/fleet_api_integration/config.fleet.ts 5m
2s\r\n```","sha":"1c777a2e702f7c5ae9c1b86063515c0a27368efb"}},"sourceBranch":"main","suggestedTargetBranches":["8.8","8.7"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.7","label":"v8.7.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"#156407
tests] split fleet_api_integration config into smaller ones
(#156407)\n\n## Summary\r\n\r\nRuntime for
`fleet_api_integration/config` crossed the 38 min limit.\r\nIdeally
config runtime should be <10 min so that pipeline can quickly\r\nretry
failed configs (we do 1 retry on CI)\r\n\r\n<img width=\"1600\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/10977896/235707744-3120e1e9-4882-493f-9ee0-86016a765401.png\">\r\n\r\n\r\nThis
PR splits the existing config into few smaller
ones:\r\n\r\n```\r\nx-pack/test/fleet_api_integration/config.agent.ts
15m 15s\r\nx-pack/test/fleet_api_integration/config.agent_policy.ts 4m
10s\r\nx-pack/test/fleet_api_integration/config.epm.ts 8m
12s\r\nx-pack/test/fleet_api_integration/config.package_policy.ts 10m
54s\r\n// combines multiple test
files\r\nx-pack/test/fleet_api_integration/config.fleet.ts 5m
2s\r\n```","sha":"1c777a2e702f7c5ae9c1b86063515c0a27368efb"}}]}]
BACKPORT-->

Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co>
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request May 5, 2023
…es (elastic#156407)

## Summary

Runtime for `fleet_api_integration/config` crossed the 38 min limit.
Ideally config runtime should be <10 min so that pipeline can quickly
retry failed configs (we do 1 retry on CI)

<img width="1600" alt="image"
src="https://user-images.githubusercontent.com/10977896/235707744-3120e1e9-4882-493f-9ee0-86016a765401.png">

This PR splits the existing config into few smaller ones:

```
x-pack/test/fleet_api_integration/config.agent.ts 15m 15s
x-pack/test/fleet_api_integration/config.agent_policy.ts 4m 10s
x-pack/test/fleet_api_integration/config.epm.ts 8m 12s
x-pack/test/fleet_api_integration/config.package_policy.ts 10m 54s
// combines multiple test files
x-pack/test/fleet_api_integration/config.fleet.ts 5m 2s
```

(cherry picked from commit 1c777a2)

# Conflicts:
#	x-pack/test/fleet_api_integration/apis/index.js
@dmlemeshko
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

dmlemeshko added a commit that referenced this pull request May 5, 2023
…ler ones (#156407) (#156851)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[functional tests] split fleet_api_integration config into smaller
ones (#156407)](#156407)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dzmitry
Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2023-05-03T14:26:58Z","message":"[functional
tests] split fleet_api_integration config into smaller ones
(#156407)\n\n## Summary\r\n\r\nRuntime for
`fleet_api_integration/config` crossed the 38 min limit.\r\nIdeally
config runtime should be <10 min so that pipeline can quickly\r\nretry
failed configs (we do 1 retry on CI)\r\n\r\n<img width=\"1600\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/10977896/235707744-3120e1e9-4882-493f-9ee0-86016a765401.png\">\r\n\r\n\r\nThis
PR splits the existing config into few smaller
ones:\r\n\r\n```\r\nx-pack/test/fleet_api_integration/config.agent.ts
15m 15s\r\nx-pack/test/fleet_api_integration/config.agent_policy.ts 4m
10s\r\nx-pack/test/fleet_api_integration/config.epm.ts 8m
12s\r\nx-pack/test/fleet_api_integration/config.package_policy.ts 10m
54s\r\n// combines multiple test
files\r\nx-pack/test/fleet_api_integration/config.fleet.ts 5m
2s\r\n```","sha":"1c777a2e702f7c5ae9c1b86063515c0a27368efb","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v8.8.0","v8.7.2","v8.9.0"],"number":156407,"url":"#156407
tests] split fleet_api_integration config into smaller ones
(#156407)\n\n## Summary\r\n\r\nRuntime for
`fleet_api_integration/config` crossed the 38 min limit.\r\nIdeally
config runtime should be <10 min so that pipeline can quickly\r\nretry
failed configs (we do 1 retry on CI)\r\n\r\n<img width=\"1600\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/10977896/235707744-3120e1e9-4882-493f-9ee0-86016a765401.png\">\r\n\r\n\r\nThis
PR splits the existing config into few smaller
ones:\r\n\r\n```\r\nx-pack/test/fleet_api_integration/config.agent.ts
15m 15s\r\nx-pack/test/fleet_api_integration/config.agent_policy.ts 4m
10s\r\nx-pack/test/fleet_api_integration/config.epm.ts 8m
12s\r\nx-pack/test/fleet_api_integration/config.package_policy.ts 10m
54s\r\n// combines multiple test
files\r\nx-pack/test/fleet_api_integration/config.fleet.ts 5m
2s\r\n```","sha":"1c777a2e702f7c5ae9c1b86063515c0a27368efb"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"#156559
[functional tests] split fleet_api_integration config into smaller ones
(#156407) (#156559)\n\n# Backport\n\nThis will backport the following
commits from `main` to `8.8`:\n- [[functional tests] split
fleet_api_integration config into smaller\nones
(#156407)](https://github.com/elastic/kibana/pull/156407)\n\n<!---
Backport version: 8.9.7 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Dzmitry\nLemechko\",\"email\":\"dzmitry.lemechko@elastic.co\"},\"sourceCommit\":{\"committedDate\":\"2023-05-03T14:26:58Z\",\"message\":\"[functional\ntests]
split fleet_api_integration config into smaller ones\n(#156407)\\n\\n##
Summary\\r\\n\\r\\nRuntime for\n`fleet_api_integration/config` crossed
the 38 min limit.\\r\\nIdeally\nconfig runtime should be <10 min so that
pipeline can quickly\\r\\nretry\nfailed configs (we do 1 retry on
CI)\\r\\n\\r\\n<img
width=\\\"1600\\\"\nalt=\\\"image\\\"\\r\\nsrc=\\\"https://user-images.githubusercontent.com/10977896/235707744-3120e1e9-4882-493f-9ee0-86016a765401.png\\\">\\r\\n\\r\\n\\r\\nThis\nPR
splits the existing config into few
smaller\nones:\\r\\n\\r\\n```\\r\\nx-pack/test/fleet_api_integration/config.agent.ts\n15m
15s\\r\\nx-pack/test/fleet_api_integration/config.agent_policy.ts
4m\n10s\\r\\nx-pack/test/fleet_api_integration/config.epm.ts
8m\n12s\\r\\nx-pack/test/fleet_api_integration/config.package_policy.ts
10m\n54s\\r\\n// combines multiple
test\nfiles\\r\\nx-pack/test/fleet_api_integration/config.fleet.ts
5m\n2s\\r\\n```\",\"sha\":\"1c777a2e702f7c5ae9c1b86063515c0a27368efb\",\"branchLabelMapping\":{\"^v8.9.0$\":\"main\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"Team:Fleet\",\"v8.8.0\",\"v8.7.2\",\"v8.9.0\"],\"number\":156407,\"url\":\"#156407
split fleet_api_integration config into smaller ones\n(#156407)\\n\\n##
Summary\\r\\n\\r\\nRuntime for\n`fleet_api_integration/config` crossed
the 38 min limit.\\r\\nIdeally\nconfig runtime should be <10 min so that
pipeline can quickly\\r\\nretry\nfailed configs (we do 1 retry on
CI)\\r\\n\\r\\n<img
width=\\\"1600\\\"\nalt=\\\"image\\\"\\r\\nsrc=\\\"https://user-images.githubusercontent.com/10977896/235707744-3120e1e9-4882-493f-9ee0-86016a765401.png\\\">\\r\\n\\r\\n\\r\\nThis\nPR
splits the existing config into few
smaller\nones:\\r\\n\\r\\n```\\r\\nx-pack/test/fleet_api_integration/config.agent.ts\n15m
15s\\r\\nx-pack/test/fleet_api_integration/config.agent_policy.ts
4m\n10s\\r\\nx-pack/test/fleet_api_integration/config.epm.ts
8m\n12s\\r\\nx-pack/test/fleet_api_integration/config.package_policy.ts
10m\n54s\\r\\n// combines multiple
test\nfiles\\r\\nx-pack/test/fleet_api_integration/config.fleet.ts
5m\n2s\\r\\n```\",\"sha\":\"1c777a2e702f7c5ae9c1b86063515c0a27368efb\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.8\",\"8.7\"],\"targetPullRequestStates\":[{\"branch\":\"8.8\",\"label\":\"v8.8.0\",\"labelRegex\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"},{\"branch\":\"8.7\",\"label\":\"v8.7.2\",\"labelRegex\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"},{\"branch\":\"main\",\"label\":\"v8.9.0\",\"labelRegex\":\"^v8.9.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"#156407
split fleet_api_integration config into smaller ones\n(#156407)\\n\\n##
Summary\\r\\n\\r\\nRuntime for\n`fleet_api_integration/config` crossed
the 38 min limit.\\r\\nIdeally\nconfig runtime should be <10 min so that
pipeline can quickly\\r\\nretry\nfailed configs (we do 1 retry on
CI)\\r\\n\\r\\n<img
width=\\\"1600\\\"\nalt=\\\"image\\\"\\r\\nsrc=\\\"https://user-images.githubusercontent.com/10977896/235707744-3120e1e9-4882-493f-9ee0-86016a765401.png\\\">\\r\\n\\r\\n\\r\\nThis\nPR
splits the existing config into few
smaller\nones:\\r\\n\\r\\n```\\r\\nx-pack/test/fleet_api_integration/config.agent.ts\n15m
15s\\r\\nx-pack/test/fleet_api_integration/config.agent_policy.ts
4m\n10s\\r\\nx-pack/test/fleet_api_integration/config.epm.ts
8m\n12s\\r\\nx-pack/test/fleet_api_integration/config.package_policy.ts
10m\n54s\\r\\n// combines multiple
test\nfiles\\r\\nx-pack/test/fleet_api_integration/config.fleet.ts
5m\n2s\\r\\n```\",\"sha\":\"1c777a2e702f7c5ae9c1b86063515c0a27368efb\"}}]}]\nBACKPORT-->\n\nCo-authored-by:
Dzmitry Lemechko
<dzmitry.lemechko@elastic.co>"}},{"branch":"8.7","label":"v8.7.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"#156407
tests] split fleet_api_integration config into smaller ones
(#156407)\n\n## Summary\r\n\r\nRuntime for
`fleet_api_integration/config` crossed the 38 min limit.\r\nIdeally
config runtime should be <10 min so that pipeline can quickly\r\nretry
failed configs (we do 1 retry on CI)\r\n\r\n<img width=\"1600\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/10977896/235707744-3120e1e9-4882-493f-9ee0-86016a765401.png\">\r\n\r\n\r\nThis
PR splits the existing config into few smaller
ones:\r\n\r\n```\r\nx-pack/test/fleet_api_integration/config.agent.ts
15m 15s\r\nx-pack/test/fleet_api_integration/config.agent_policy.ts 4m
10s\r\nx-pack/test/fleet_api_integration/config.epm.ts 8m
12s\r\nx-pack/test/fleet_api_integration/config.package_policy.ts 10m
54s\r\n// combines multiple test
files\r\nx-pack/test/fleet_api_integration/config.fleet.ts 5m
2s\r\n```","sha":"1c777a2e702f7c5ae9c1b86063515c0a27368efb"}}]}]
BACKPORT-->
@dmlemeshko dmlemeshko deleted the ftr/split-fleet-api-integration-config branch November 21, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.7.2 v8.8.0 v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants