-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.8] [functional tests] split fleet_api_integration config into smaller ones (#156407) #156559
Merged
kibanamachine
merged 1 commit into
elastic:8.8
from
kibanamachine:backport/8.8/pr-156407
May 3, 2023
Merged
[8.8] [functional tests] split fleet_api_integration config into smaller ones (#156407) #156559
kibanamachine
merged 1 commit into
elastic:8.8
from
kibanamachine:backport/8.8/pr-156407
May 3, 2023
+156
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es (elastic#156407) ## Summary Runtime for `fleet_api_integration/config` crossed the 38 min limit. Ideally config runtime should be <10 min so that pipeline can quickly retry failed configs (we do 1 retry on CI) <img width="1600" alt="image" src="https://user-images.githubusercontent.com/10977896/235707744-3120e1e9-4882-493f-9ee0-86016a765401.png"> This PR splits the existing config into few smaller ones: ``` x-pack/test/fleet_api_integration/config.agent.ts 15m 15s x-pack/test/fleet_api_integration/config.agent_policy.ts 4m 10s x-pack/test/fleet_api_integration/config.epm.ts 8m 12s x-pack/test/fleet_api_integration/config.package_policy.ts 10m 54s // combines multiple test files x-pack/test/fleet_api_integration/config.fleet.ts 5m 2s ``` (cherry picked from commit 1c777a2)
botelastic
bot
added
the
Team:Fleet
Team label for Observability Data Collection Fleet team
label
May 3, 2023
Pinging @elastic/fleet (Team:Fleet) |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @dmlemeshko |
dmlemeshko
added a commit
that referenced
this pull request
May 5, 2023
…ler ones (#156407) (#156851) # Backport This will backport the following commits from `main` to `8.7`: - [[functional tests] split fleet_api_integration config into smaller ones (#156407)](#156407) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dzmitry Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2023-05-03T14:26:58Z","message":"[functional tests] split fleet_api_integration config into smaller ones (#156407)\n\n## Summary\r\n\r\nRuntime for `fleet_api_integration/config` crossed the 38 min limit.\r\nIdeally config runtime should be <10 min so that pipeline can quickly\r\nretry failed configs (we do 1 retry on CI)\r\n\r\n<img width=\"1600\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/10977896/235707744-3120e1e9-4882-493f-9ee0-86016a765401.png\">\r\n\r\n\r\nThis PR splits the existing config into few smaller ones:\r\n\r\n```\r\nx-pack/test/fleet_api_integration/config.agent.ts 15m 15s\r\nx-pack/test/fleet_api_integration/config.agent_policy.ts 4m 10s\r\nx-pack/test/fleet_api_integration/config.epm.ts 8m 12s\r\nx-pack/test/fleet_api_integration/config.package_policy.ts 10m 54s\r\n// combines multiple test files\r\nx-pack/test/fleet_api_integration/config.fleet.ts 5m 2s\r\n```","sha":"1c777a2e702f7c5ae9c1b86063515c0a27368efb","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v8.8.0","v8.7.2","v8.9.0"],"number":156407,"url":"https://github.com/elastic/kibana/pull/156407","mergeCommit":{"message":"[functional tests] split fleet_api_integration config into smaller ones (#156407)\n\n## Summary\r\n\r\nRuntime for `fleet_api_integration/config` crossed the 38 min limit.\r\nIdeally config runtime should be <10 min so that pipeline can quickly\r\nretry failed configs (we do 1 retry on CI)\r\n\r\n<img width=\"1600\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/10977896/235707744-3120e1e9-4882-493f-9ee0-86016a765401.png\">\r\n\r\n\r\nThis PR splits the existing config into few smaller ones:\r\n\r\n```\r\nx-pack/test/fleet_api_integration/config.agent.ts 15m 15s\r\nx-pack/test/fleet_api_integration/config.agent_policy.ts 4m 10s\r\nx-pack/test/fleet_api_integration/config.epm.ts 8m 12s\r\nx-pack/test/fleet_api_integration/config.package_policy.ts 10m 54s\r\n// combines multiple test files\r\nx-pack/test/fleet_api_integration/config.fleet.ts 5m 2s\r\n```","sha":"1c777a2e702f7c5ae9c1b86063515c0a27368efb"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/156559","number":156559,"state":"MERGED","mergeCommit":{"sha":"d61043fdfa0b07f5156a1f78d42b6640e90edd1c","message":"[8.8] [functional tests] split fleet_api_integration config into smaller ones (#156407) (#156559)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.8`:\n- [[functional tests] split fleet_api_integration config into smaller\nones (#156407)](https://github.com/elastic/kibana/pull/156407)\n\n<!--- Backport version: 8.9.7 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Dzmitry\nLemechko\",\"email\":\"dzmitry.lemechko@elastic.co\"},\"sourceCommit\":{\"committedDate\":\"2023-05-03T14:26:58Z\",\"message\":\"[functional\ntests] split fleet_api_integration config into smaller ones\n(#156407)\\n\\n## Summary\\r\\n\\r\\nRuntime for\n`fleet_api_integration/config` crossed the 38 min limit.\\r\\nIdeally\nconfig runtime should be <10 min so that pipeline can quickly\\r\\nretry\nfailed configs (we do 1 retry on CI)\\r\\n\\r\\n<img width=\\\"1600\\\"\nalt=\\\"image\\\"\\r\\nsrc=\\\"https://user-images.githubusercontent.com/10977896/235707744-3120e1e9-4882-493f-9ee0-86016a765401.png\\\">\\r\\n\\r\\n\\r\\nThis\nPR splits the existing config into few smaller\nones:\\r\\n\\r\\n```\\r\\nx-pack/test/fleet_api_integration/config.agent.ts\n15m 15s\\r\\nx-pack/test/fleet_api_integration/config.agent_policy.ts 4m\n10s\\r\\nx-pack/test/fleet_api_integration/config.epm.ts 8m\n12s\\r\\nx-pack/test/fleet_api_integration/config.package_policy.ts 10m\n54s\\r\\n// combines multiple test\nfiles\\r\\nx-pack/test/fleet_api_integration/config.fleet.ts 5m\n2s\\r\\n```\",\"sha\":\"1c777a2e702f7c5ae9c1b86063515c0a27368efb\",\"branchLabelMapping\":{\"^v8.9.0$\":\"main\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"Team:Fleet\",\"v8.8.0\",\"v8.7.2\",\"v8.9.0\"],\"number\":156407,\"url\":\"https://github.com/elastic/kibana/pull/156407\",\"mergeCommit\":{\"message\":\"[functional\ntests] split fleet_api_integration config into smaller ones\n(#156407)\\n\\n## Summary\\r\\n\\r\\nRuntime for\n`fleet_api_integration/config` crossed the 38 min limit.\\r\\nIdeally\nconfig runtime should be <10 min so that pipeline can quickly\\r\\nretry\nfailed configs (we do 1 retry on CI)\\r\\n\\r\\n<img width=\\\"1600\\\"\nalt=\\\"image\\\"\\r\\nsrc=\\\"https://user-images.githubusercontent.com/10977896/235707744-3120e1e9-4882-493f-9ee0-86016a765401.png\\\">\\r\\n\\r\\n\\r\\nThis\nPR splits the existing config into few smaller\nones:\\r\\n\\r\\n```\\r\\nx-pack/test/fleet_api_integration/config.agent.ts\n15m 15s\\r\\nx-pack/test/fleet_api_integration/config.agent_policy.ts 4m\n10s\\r\\nx-pack/test/fleet_api_integration/config.epm.ts 8m\n12s\\r\\nx-pack/test/fleet_api_integration/config.package_policy.ts 10m\n54s\\r\\n// combines multiple test\nfiles\\r\\nx-pack/test/fleet_api_integration/config.fleet.ts 5m\n2s\\r\\n```\",\"sha\":\"1c777a2e702f7c5ae9c1b86063515c0a27368efb\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.8\",\"8.7\"],\"targetPullRequestStates\":[{\"branch\":\"8.8\",\"label\":\"v8.8.0\",\"labelRegex\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"},{\"branch\":\"8.7\",\"label\":\"v8.7.2\",\"labelRegex\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"},{\"branch\":\"main\",\"label\":\"v8.9.0\",\"labelRegex\":\"^v8.9.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/156407\",\"number\":156407,\"mergeCommit\":{\"message\":\"[functional\ntests] split fleet_api_integration config into smaller ones\n(#156407)\\n\\n## Summary\\r\\n\\r\\nRuntime for\n`fleet_api_integration/config` crossed the 38 min limit.\\r\\nIdeally\nconfig runtime should be <10 min so that pipeline can quickly\\r\\nretry\nfailed configs (we do 1 retry on CI)\\r\\n\\r\\n<img width=\\\"1600\\\"\nalt=\\\"image\\\"\\r\\nsrc=\\\"https://user-images.githubusercontent.com/10977896/235707744-3120e1e9-4882-493f-9ee0-86016a765401.png\\\">\\r\\n\\r\\n\\r\\nThis\nPR splits the existing config into few smaller\nones:\\r\\n\\r\\n```\\r\\nx-pack/test/fleet_api_integration/config.agent.ts\n15m 15s\\r\\nx-pack/test/fleet_api_integration/config.agent_policy.ts 4m\n10s\\r\\nx-pack/test/fleet_api_integration/config.epm.ts 8m\n12s\\r\\nx-pack/test/fleet_api_integration/config.package_policy.ts 10m\n54s\\r\\n// combines multiple test\nfiles\\r\\nx-pack/test/fleet_api_integration/config.fleet.ts 5m\n2s\\r\\n```\",\"sha\":\"1c777a2e702f7c5ae9c1b86063515c0a27368efb\"}}]}]\nBACKPORT-->\n\nCo-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co>"}},{"branch":"8.7","label":"v8.7.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156407","number":156407,"mergeCommit":{"message":"[functional tests] split fleet_api_integration config into smaller ones (#156407)\n\n## Summary\r\n\r\nRuntime for `fleet_api_integration/config` crossed the 38 min limit.\r\nIdeally config runtime should be <10 min so that pipeline can quickly\r\nretry failed configs (we do 1 retry on CI)\r\n\r\n<img width=\"1600\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/10977896/235707744-3120e1e9-4882-493f-9ee0-86016a765401.png\">\r\n\r\n\r\nThis PR splits the existing config into few smaller ones:\r\n\r\n```\r\nx-pack/test/fleet_api_integration/config.agent.ts 15m 15s\r\nx-pack/test/fleet_api_integration/config.agent_policy.ts 4m 10s\r\nx-pack/test/fleet_api_integration/config.epm.ts 8m 12s\r\nx-pack/test/fleet_api_integration/config.package_policy.ts 10m 54s\r\n// combines multiple test files\r\nx-pack/test/fleet_api_integration/config.fleet.ts 5m 2s\r\n```","sha":"1c777a2e702f7c5ae9c1b86063515c0a27368efb"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
main
to8.8
:Questions ?
Please refer to the Backport tool documentation