-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] [Exceptions] Auto-populate exception flyout with alert’s “highlighted fields” values #159029
[Security Solution] [Exceptions] Auto-populate exception flyout with alert’s “highlighted fields” values #159029
Conversation
…topopulate-rule-exception-with-highlightedfields
.../plugins/security_solution/public/common/components/event_details/get_alert_summary_rows.tsx
Outdated
Show resolved
Hide resolved
.../plugins/security_solution/public/common/components/event_details/get_alert_summary_rows.tsx
Outdated
Show resolved
Hide resolved
...y_solution/public/detection_engine/rule_exceptions/components/add_exception_flyout/index.tsx
Outdated
Show resolved
Hide resolved
...tion/public/detection_engine/rule_exceptions/components/add_exception_flyout/translations.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/utils/helpers.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/utils/helpers.tsx
Show resolved
Hide resolved
…topopulate-rule-exception-with-highlightedfields
…topopulate-rule-exception-with-highlightedfields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed code and pulled down to play around with it. LGTM!
I think it's worth adding a cypress test for it, but that can also be done after this goes in as there are unit tests here. I would just create a ticket to track some of the additional improvements we discussed around allowing all alert document fields to be available in the dropdown for a user when they're adding an exception from the alerts flow.
Thanks for adding this Wafaa!
…topopulate-rule-exception-with-highlightedfields
ab59662
to
a88527c
Compare
…topopulate-rule-exception-with-highlightedfields
...tion/public/detection_engine/rule_exceptions/components/add_exception_flyout/translations.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @WafaaNasr for working on this feature. This should help a lot our customers in their workflows!
x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/utils/helpers.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/utils/helpers.tsx
Show resolved
Hide resolved
...security_solution/public/detection_engine/rule_exceptions/utils/highlighted_fields_config.ts
Show resolved
Hide resolved
…topopulate-rule-exception-with-highlightedfields
…topopulate-rule-exception-with-highlightedfields
…topopulate-rule-exception-with-highlightedfields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing comments and creating issues for discovered bugs
…topopulate-rule-exception-with-highlightedfields
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @WafaaNasr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the threat-hunting-investigations team!
Summary
Contents of this PR:
getEventFieldsToDisplay
function from the AlertSummary component, which retrieves the Highlighted Fields based on the Event data and Rule get_alert_summary_rows.tsxalertData
in the add_exception_flyout component.Rule Exception
add_exception_flyout on initiation, if alertData is provided and listType isRuleException
, with the highlighted fields from the Alert.Screenshots
Checklist