[8.10] [Rule Details] - Update rule details data view id text (#164494) #165015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Resolves: elastic#164828 **Related UX writing issue: elastic/ux-writing#46 ## Summary In rule details page, when a rule has a data view selected, two labels show up as "Data View". This appears to be a bug, as one of those labels should be "Data view ID" and another should be "Data view index pattern". Thanks to @MadameSheema @nikitaindik for finding this. ### Before  ### After <img width="808" alt="Screenshot 2023-08-26 at 19 30 54" src="https://github.com/elastic/kibana/assets/15949146/b511bf92-0e90-4455-834c-36b8e75b2a58"> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) --------- Co-authored-by: Nikita Indik <nikita.indik@elastic.co> (cherry picked from commit 31e9557)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
1 task
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]Async chunks
HistoryTo update your PR or re-run it, just comment with: cc @yctercero |
nikitaindik
referenced
this pull request
Aug 28, 2023
#165021) # Backport This will backport the following commits from `main` to `8.9`: - [[Rule Details] - Update rule details data view id text (#164494)](#164494) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Yara Tercero","email":"yctercero@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-08-28T16:29:00Z","message":"[Rule Details] - Update rule details data view id text (#164494)\n\n**Resolves: https://github.com/elastic/kibana/issues/164828**\r\n**Related UX writing issue:\r\nhttps://github.com/elastic/ux-writing/issues/46**\r\n\r\n## Summary\r\n\r\nIn rule details page, when a rule has a data view selected, two labels\r\nshow up as \"Data View\". This appears to be a bug, as one of those labels\r\nshould be \"Data view ID\" and another should be \"Data view index\r\npattern\".\r\n\r\nThanks to @MadameSheema @nikitaindik for finding this. \r\n\r\n### Before \r\n\r\n\r\n\r\n### After\r\n<img width=\"808\" alt=\"Screenshot 2023-08-26 at 19 30 54\"\r\nsrc=\"https://github.com/elastic/kibana/assets/15949146/b511bf92-0e90-4455-834c-36b8e75b2a58\">\r\n\r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n---------\r\n\r\nCo-authored-by: Nikita Indik <nikita.indik@elastic.co>","sha":"31e95574ae6d8cfa9e0ba4595e1068e9391b423d","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Detection Rule Management","ui-copy","Feature:Rule Details","Team:Detection Engine","v8.10.0","v8.11.0","v8.9.2"],"number":164494,"url":"https://github.com/elastic/kibana/pull/164494","mergeCommit":{"message":"[Rule Details] - Update rule details data view id text (#164494)\n\n**Resolves: https://github.com/elastic/kibana/issues/164828**\r\n**Related UX writing issue:\r\nhttps://github.com/elastic/ux-writing/issues/46**\r\n\r\n## Summary\r\n\r\nIn rule details page, when a rule has a data view selected, two labels\r\nshow up as \"Data View\". This appears to be a bug, as one of those labels\r\nshould be \"Data view ID\" and another should be \"Data view index\r\npattern\".\r\n\r\nThanks to @MadameSheema @nikitaindik for finding this. \r\n\r\n### Before \r\n\r\n\r\n\r\n### After\r\n<img width=\"808\" alt=\"Screenshot 2023-08-26 at 19 30 54\"\r\nsrc=\"https://github.com/elastic/kibana/assets/15949146/b511bf92-0e90-4455-834c-36b8e75b2a58\">\r\n\r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n---------\r\n\r\nCo-authored-by: Nikita Indik <nikita.indik@elastic.co>","sha":"31e95574ae6d8cfa9e0ba4595e1068e9391b423d"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/165015","number":165015,"state":"OPEN"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164494","number":164494,"mergeCommit":{"message":"[Rule Details] - Update rule details data view id text (#164494)\n\n**Resolves: https://github.com/elastic/kibana/issues/164828**\r\n**Related UX writing issue:\r\nhttps://github.com/elastic/ux-writing/issues/46**\r\n\r\n## Summary\r\n\r\nIn rule details page, when a rule has a data view selected, two labels\r\nshow up as \"Data View\". This appears to be a bug, as one of those labels\r\nshould be \"Data view ID\" and another should be \"Data view index\r\npattern\".\r\n\r\nThanks to @MadameSheema @nikitaindik for finding this. \r\n\r\n### Before \r\n\r\n\r\n\r\n### After\r\n<img width=\"808\" alt=\"Screenshot 2023-08-26 at 19 30 54\"\r\nsrc=\"https://github.com/elastic/kibana/assets/15949146/b511bf92-0e90-4455-834c-36b8e75b2a58\">\r\n\r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n---------\r\n\r\nCo-authored-by: Nikita Indik <nikita.indik@elastic.co>","sha":"31e95574ae6d8cfa9e0ba4595e1068e9391b423d"}},{"branch":"8.9","label":"v8.9.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.10:Questions ?
Please refer to the Backport tool documentation