[Fleet] Agent upgrade available should use latest agent version #167410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaElastic
added
the
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
juliaElastic
commented
Sep 28, 2023
| @@ -60,8 +60,7 @@ export const getAvailableVersions = async ({ | |||
| .sort((a: any, b: any) => (semverGt(a, b) ? -1 : 1)); | |||
| versionsToDisplay = uniq(versions) as string[]; | |||
|
|
|||
| const appendCurrentVersion = | |||
| includeCurrentVersion ?? !config?.internal?.onlyAllowAgentUpgradeToKnownVersions; | |||
| const appendCurrentVersion = includeCurrentVersion; | |||
There was a problem hiding this comment.
changed this not to include kibana version in stateful neither, as it's not correct for unreleased versions:
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.11.0
backport:skip
This was referenced Oct 2, 2023
juliaElastic
added a commit
that referenced
this pull request
Oct 2, 2023
## Summary The recent [change](#167410) broke an integration test in agent where the test upgrades to a newer snapshot version. This change is removing the version check against the latest agent version if `versionToUpgrade` is given. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #167387
Replaced using kibana version when deciding if agent upgrade is available (only in serverless, in stateful kibana version is still returned as an available version).
To verify locally:
kibana.dev.yml:xpack.fleet.internal.onlyAllowAgentUpgradeToKnownVersions: trueagent_versions_list.jsonto local kibana folder~/kibana/x-pack/plugins/fleet/targetagent_versions_list.json.zip
Agent list:
Upgrade available filter - 1 agent on latest version, 9 upgradeable:
Agent details:
Agent on latest version has disable
Upgrade agentaction:Bulk action with one agent that is not upgradeable (already on latest version), expected error:
Checklist