Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] fix upgradeable check to allow to newer snapshot #167780

Merged
merged 2 commits into from
Oct 2, 2023
Merged

[Fleet] fix upgradeable check to allow to newer snapshot #167780

merged 2 commits into from
Oct 2, 2023
+14 −42

Conversation

juliaElastic
Copy link
Contributor

Summary

The recent change broke an integration test in agent where the test upgrades to a newer snapshot version.

This change is removing the version check against the latest agent version if versionToUpgrade is given.

Checklist

@juliaElastic juliaElastic added the release_note:skip Skip the PR/issue when compiling release notes label Oct 2, 2023
@juliaElastic juliaElastic requested a review from a team as a code owner October 2, 2023 13:44
@juliaElastic juliaElastic self-assigned this Oct 2, 2023
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Oct 2, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

criamico
criamico reviewed Oct 2, 2023
View reviewed changes
x-pack/plugins/fleet/common/services/is_agent_upgradeable.test.ts
'8.0.0-SNAPSHOT'
getAgent({ version: '8.10.2', upgradeable: true }),
'8.10.2',
'8.11.0-SNAPSHOT'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test should cover the case that was failing, correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

criamico
criamico approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@criamico criamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@juliaElastic juliaElastic enabled auto-merge (squash) October 2, 2023 13:54
@pchila pchila mentioned this pull request Oct 2, 2023
Closed
7 tasks
@juliaElastic juliaElastic merged commit 2bcd865 into elastic:main Oct 2, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #11 / dashboard app - group 4 dashboard empty state adds a new data view when no data views
  • [job] [logs] FTR Configs #49 / serverless security UI Security advanced settings "before all" hook for "renders the page"

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 146.7KB 146.7KB -8.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @juliaElastic

@kibanamachine kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@criamico criamico criamico approved these changes

@michalpristas michalpristas michalpristas approved these changes

Assignees

@juliaElastic juliaElastic

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@juliaElastic @elasticmachine @apmmachine @kibana-ci @michalpristas @criamico @kibanamachine