Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Reduce flakiness in ransomware tests #173316

Merged
merged 2 commits into from
Dec 14, 2023
Merged

[Security Solution] Reduce flakiness in ransomware tests #173316

merged 2 commits into from
Dec 14, 2023

Conversation

christineweng
Copy link
Contributor

@christineweng christineweng commented Dec 13, 2023 •
edited
Loading

Summary

before -> beforeEach to prevent missing timeline on retry
Unload data after test finish

Fixes: #170310
Fixes: #170846

Checklist

@christineweng christineweng self-assigned this Dec 13, 2023
@christineweng christineweng added release_note:fix backport:skip This commit does not require backporting Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Investigations Security Solution Investigations Team v8.12.0 labels Dec 13, 2023
@christineweng christineweng marked this pull request as ready for review December 13, 2023 19:47
@christineweng christineweng requested review from a team as code owners December 13, 2023 19:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@christineweng christineweng changed the title [Security Solution] Improve flakiness in ransomware_prevention.cy [Security Solution] Reduce flakiness in ransomware_prevention.cy Dec 13, 2023
@christineweng christineweng changed the title [Security Solution] Reduce flakiness in ransomware_prevention.cy [Security Solution] Reduce flakiness in ransomware tests Dec 13, 2023
@christineweng christineweng marked this pull request as draft December 13, 2023 20:32
@christineweng christineweng added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:fix labels Dec 13, 2023
PhilippeOberti
PhilippeOberti reviewed Dec 13, 2023
View reviewed changes
Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comments, let me know what you think!

.../test/security_solution_cypress/cypress/e2e/investigations/alerts/ransomware_detection.cy.ts Show resolved Hide resolved
.../test/security_solution_cypress/cypress/e2e/investigations/alerts/ransomware_detection.cy.ts Outdated Show resolved Hide resolved
...test/security_solution_cypress/cypress/e2e/investigations/alerts/ransomware_prevention.cy.ts Outdated Show resolved Hide resolved
...test/security_solution_cypress/cypress/e2e/investigations/alerts/ransomware_prevention.cy.ts Show resolved Hide resolved
@christineweng
Copy link
Contributor Author

Thank you @PhilippeOberti for the thorough review! :)

@christineweng christineweng marked this pull request as ready for review December 14, 2023 16:59
@christineweng christineweng mentioned this pull request Dec 14, 2023
Closed
25 tasks
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💔 Build #183522 failed edff4421a7576033d3b71dd372cf36385dcbb78d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @christineweng

PhilippeOberti
PhilippeOberti approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect thank you!

@PhilippeOberti PhilippeOberti mentioned this pull request Dec 14, 2023
Closed
@christineweng christineweng merged commit 0711efc into elastic:main Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeOberti PhilippeOberti PhilippeOberti approved these changes

Assignees

@christineweng christineweng

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v8.12.0 v8.13.0
Projects
None yet
Milestone
No milestone
5 participants
@christineweng @elasticmachine @kibana-ci @PhilippeOberti @kibanamachine