Expand coverage of dashboard tests #17703

stacey-gammon · 2018-04-13T18:17:44Z

I created new test data from the 6.x branch so it's correctly labeled as 6.3. I created new visualizations for every type we have so we don't have to spend time creating these visualizations during the tests. I'm also doing some ad hoc rendering/snapshot testing by checking on certain css classes. A bit fragile but not as fragile as the actual visual regression testing, and much faster.

elasticmachine · 2018-04-25T18:15:44Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

chrisdavies

Dang. That's a lot of work. This looks great to me. I really like the helper classes you put together to consolodate common test functionality. I may steal a page from this book in my migrations testing!

chrisdavies · 2018-04-27T13:09:09Z

src/core_plugins/kibana/public/dashboard/panel/__snapshots__/dashboard_panel.test.js.snap

@@ -10,6 +10,7 @@ exports[`DashboardPanel matches snapshot 1`] = `
 >
 <div
 class="panel-heading"
+ data-test-subj="dashboardPanelHeading-"


This looks like it's missing info after the - was it supposed to have some value there, like the title? Probably not important.

There isn't a title in the test data for this, but I can add it in so it tests that the title is there and that it doesn't look like a mistake.

chrisdavies · 2018-04-27T13:27:27Z

test/functional/page_objects/dashboard_page.js

- async setCustomPanelTitle(customTitle, panel) {
- log.debug(`setCustomPanelTitle(${customTitle}, ${panel})`);
- await this.openPanelOptions(panel);
+ /**


Honestly, this is the only place in this entire file that jsdoc comments are used. I'd personally get rid of them, and just add a descriptive // comment if you think one is necessary. Buuuut that's maybe terrible advice.

As we move towards typescript, these kinds of comments will become more prolific. This does look inconsistent, but if the function deserves a comment (I thought it did, originalTitle doesn't obviously reflect that it's being used to find the panel to change, and that it's optional), I think it might as well be jsdoc vs //. Appreciate the feedback, but I think I'll leave this one here.

chrisdavies · 2018-04-27T13:29:37Z

test/functional/services/filter_bar.js

+ /**
+ *
+ * @param field
+ * @param operator


Same here. The comment block is fairly useless except for the inputType clarification, IMO.

Agree on this one, I'll remove. not to mention the variable name is wrong :).

elasticmachine · 2018-04-30T13:34:02Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

nreese

This looks great. I really like how it breaks the functional tests into smaller files.

nreese · 2018-04-30T15:28:23Z

test/functional/services/time_picker.js

@@ -0,0 +1,14 @@
+export function TimePickerProvider({ getService }) {


Looks like this is never used anywhere

nreese · 2018-04-30T15:30:03Z

test/functional/services/filter_bar.js

 async getFilterFieldIndexPatterns() {
 const indexPatterns = [];
 const groups = await find.allByCssSelector('.ui-select-choices-group-label');
+ console.log('found ' + groups.length + ' index pattern group labels');


Should this use log server?

nreese · 2018-04-30T15:32:39Z

test/functional/apps/dashboard/_embed_mode.js

+ });
+
+ after(async function () {
+ console.log('showing chrome again');


Should this use log service?

elasticmachine · 2018-04-30T18:28:11Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

stacey-gammon · 2018-05-01T11:56:37Z

Failed on:

18:18:58        │ info  Current URL is: http://localhost:5620/app/kibana#/management/kibana/objects?_g=()&_a=(tab:searches)
18:18:58        │ info  Saving page source to: /var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-selenium/kibana/test/functional/failure_debug/html/management import objects should handle saved searches and objects with saved searches properly.html
18:18:58      └- ✖ fail: "management import objects should handle saved searches and objects with saved searches properly"
18:18:58      │        Error: expected 0 to equal 1
18:18:58      │         at Assertion.assert (node_modules/expect.js/index.js:96:13)
18:18:58      │         at Assertion.be.Assertion.equal (node_modules/expect.js/index.js:216:10)
18:18:58      │         at Assertion.(anonymous function) [as be] (node_modules/expect.js/index.js:69:24)
18:18:58      │         at Context.<anonymous> (test/functional/apps/management/_import_objects.js:128:48)
18:18:58      │         at <anonymous>:null:null

Looks to be a flaky test:

Filed #18682

Will rebase and test again.

…icking

…view pages

… migrating the data as we progress

elasticmachine · 2018-05-01T13:00:54Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

* Expand coverage of dashboard tests and decrease time * Fix timing error when sub urls fail to save from too fast app link clicking * discover doesn't have breadcrumbs * Check top nav text so it works on both listing and saved object edit/view pages * need to do the add panel operations one at a time * Need both types of input in filter * Give test data a title * Remove incorrect and unnecessary comment * Move data around and get rid of 6_3 specific naming as we will end up migrating the data as we progress * Remove code accidentally checked in

stacey-gammon added test Feature:Dashboard Dashboard related features :Sharing labels Apr 13, 2018

stacey-gammon force-pushed the 2018-04-update-dashboard-test-data branch 2 times, most recently from 4d9c1c1 to 4703433 Compare April 13, 2018 22:08

stacey-gammon changed the title ~~Expand coverage of dashboard tests and decrease time~~ Expand coverage of dashboard tests Apr 13, 2018

stacey-gammon force-pushed the 2018-04-update-dashboard-test-data branch 3 times, most recently from c03c37f to cc4122c Compare April 16, 2018 14:54

stacey-gammon mentioned this pull request Apr 17, 2018

Fix issue with overwritten filters #17713

Merged

stacey-gammon force-pushed the 2018-04-update-dashboard-test-data branch 12 times, most recently from bc46a6a to 6081dbd Compare April 18, 2018 22:40

stacey-gammon mentioned this pull request Apr 18, 2018

Meta: Custom time ranges per panel #17776

Closed

7 tasks

stacey-gammon force-pushed the 2018-04-update-dashboard-test-data branch 6 times, most recently from 99a7145 to a8c6f25 Compare April 25, 2018 12:20

stacey-gammon requested review from nreese and chrisdavies April 26, 2018 19:09

chrisdavies approved these changes Apr 27, 2018

View reviewed changes

stacey-gammon force-pushed the 2018-04-update-dashboard-test-data branch from c4c7d36 to fd068b8 Compare April 30, 2018 14:53

nreese reviewed Apr 30, 2018

View reviewed changes

stacey-gammon force-pushed the 2018-04-update-dashboard-test-data branch from fd068b8 to 26a7bdf Compare April 30, 2018 17:00

stacey-gammon added 10 commits May 1, 2018 07:56

Expand coverage of dashboard tests and decrease time

8aca460

Fix timing error when sub urls fail to save from too fast app link cl…

8ebf638

…icking

discover doesn't have breadcrumbs

b9723e6

Check top nav text so it works on both listing and saved object edit/…

37f2ce4

…view pages

need to do the add panel operations one at a time

efcfbcb

Need both types of input in filter

866ca39

Give test data a title

fc0c4bd

Remove incorrect and unnecessary comment

9d4ca8a

Move data around and get rid of 6_3 specific naming as we will end up…

ddb7c58

… migrating the data as we progress

Remove code accidentally checked in

961e82c

stacey-gammon force-pushed the 2018-04-update-dashboard-test-data branch from 26a7bdf to 961e82c Compare May 1, 2018 11:57

stacey-gammon merged commit 3c8c23c into elastic:master May 1, 2018

stacey-gammon mentioned this pull request May 1, 2018

[6.x] Expand coverage of dashboard tests (#17703) #18684

Closed

stacey-gammon mentioned this pull request May 7, 2018

[6.x] Expand coverage of dashboard tests (#17703) #18861

Merged

stacey-gammon added v6.4.0 v7.0.0 labels May 8, 2018

stacey-gammon deleted the 2018-04-update-dashboard-test-data branch June 11, 2019 16:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expand coverage of dashboard tests #17703

Expand coverage of dashboard tests #17703

stacey-gammon commented Apr 13, 2018

elasticmachine commented Apr 25, 2018

chrisdavies left a comment

chrisdavies Apr 27, 2018

stacey-gammon Apr 30, 2018

chrisdavies Apr 27, 2018

stacey-gammon Apr 30, 2018

chrisdavies Apr 27, 2018

stacey-gammon Apr 30, 2018

elasticmachine commented Apr 30, 2018

nreese left a comment

nreese Apr 30, 2018

nreese Apr 30, 2018

nreese Apr 30, 2018

elasticmachine commented Apr 30, 2018

stacey-gammon commented May 1, 2018

elasticmachine commented May 1, 2018

		@@ -0,0 +1,14 @@
		export function TimePickerProvider({ getService }) {

Expand coverage of dashboard tests #17703

Expand coverage of dashboard tests #17703

Conversation

stacey-gammon commented Apr 13, 2018

elasticmachine commented Apr 25, 2018

💔 Build Failed

chrisdavies left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Apr 30, 2018

💚 Build Succeeded

nreese left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Apr 30, 2018

💔 Build Failed

stacey-gammon commented May 1, 2018

elasticmachine commented May 1, 2018

💚 Build Succeeded