Fix issue with overwritten filters

[timroes]

Fixes #17644

This fixes overwriting filters on the search source in courier request handler, and thus losing all filters saved with the visualization.

After talking to @spalger we decided, that we don't start passing filters/queries explicitly for now in this place, without having a clear idea about how the removal of inheritance in search source would work in all of Kibana. Search source is currently built around inheritance, and breaking it in just one tiny part (the courier request handler) we cannot assure, that anything would still work properly.

So instead we are doing the very "easy" solution, by just inheriting another time per request from the searchSource and apply the timeRange filter to that search source. We still need two more modifications for this to work:

• We need to mirror the history of the inherited search source with the original one, so that spy panel will still work, since spy panel will read out of searchSource, but the request will actually be written into requestSearchSource's history. This works by mirroring both. @spalger in contrast to our discussions on Friday, I haven't put this in a general way into the inherit method, since this a) would have cluttered the SearchSource class even more for just this one small usage of it, that b) can be removed as soon as the inspector (Replace spy panels by Inspector #16387) is implemented, since it's currently the only feature using history at all. So I rather decided to leave it in the courier request handler, and thus this simple defineProperty works, without needing to take care of overwriting the property if inheritance should change, etc.
• We need to call the parents search source's onRequestStart handlers, since these will be used to properly trigger preflight requests (e.g. determine the interval for date histograms with auto interval). If we don't trigger the searchSource handlers only the requestSearchSource handlers, the preflight requests attached to vis won't be triggered properly. This needs to be configurable by a flag, since we would otherwise trigger parent handlers also for the postflight requests, since they inherit from requestSearchSource, but we don't want one preflight request trigger per postflight request.

cc @stacey-gammon (for information about the postpone of explicit filter/query passing - also feel free to review, if you have the time :))

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[timroes]

Jenkins, test this - the saved search was missing in the test case?

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[ppisljar]

LGTM

[spalger]

LGTM

[nyurik]

Seems like we need to add some tests to both timelion & vega to check for this.

[timroes]

Since timelion and Vega doesn't support this at all, there is at the moment no need to add tests for it :) (see #17719)

[stacey-gammon]

@nyurik - @timroes is right but I have a test that will cover this case here: #17688 and I am also working on adding more timelion/vega tests here: #17703 (that last one is still in progress).