Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboard Transaction Error Rate rule type with FAAD #179496

Merged

Conversation

doakalexi
Copy link
Contributor

@doakalexi doakalexi commented Mar 26, 2024

Towards: #169867

This PR onboards the Transaction Error Rate rule type with FAAD.

To verify

  1. Run the following script to generate APM data:
node scripts/synthtrace many_errors.ts --local --live
  1. Create a transaction error rate rule.
    Example:
POST kbn:/api/alerting/rule
{
  "params": {
    "threshold": 0,
    "windowSize": 5,
    "windowUnit": "m",
    "environment": "ENVIRONMENT_ALL"
  },
  "consumer": "alerts",
  "schedule": {
    "interval": "1m"
  },
  "tags": [],
  "name": "test",
  "rule_type_id": "apm.transaction_error_rate",
  "notify_when": "onActionGroupChange",
  "actions": []
}
  1. Your rule should create an alert and should saved it in .internal.alerts-observability.apm.alerts-default-000001
    Example:
GET .internal.alerts-*/_search
  1. Recover the alert by setting threshold: 200

  2. The alert should be recovered and the AAD in the above index should be updated kibana.alert.status: recovered.

@doakalexi
Copy link
Contributor Author

/ci

@doakalexi
Copy link
Contributor Author

/ci

@doakalexi doakalexi changed the title Initial commit onboarding the transaction error rate rule Onboard Transaction Error Rate rule type with FAAD Apr 2, 2024
@doakalexi doakalexi added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) release_note:skip Skip the PR/issue when compiling release notes v8.14.0 labels Apr 2, 2024
@doakalexi doakalexi self-assigned this Apr 2, 2024
@doakalexi
Copy link
Contributor Author

/ci

@doakalexi doakalexi added v8.15.0 and removed v8.14.0 labels Apr 16, 2024
@doakalexi doakalexi requested review from a team, ymao1 and js-jankisalvi April 16, 2024 18:29
@doakalexi doakalexi marked this pull request as ready for review April 16, 2024 18:29
@doakalexi doakalexi requested a review from a team as a code owner April 16, 2024 18:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

Copy link
Contributor

@js-jankisalvi js-jankisalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified locally, works as expected

@botelastic botelastic bot added the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label Apr 17, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doakalexi doakalexi enabled auto-merge (squash) April 17, 2024 21:00
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Verified creating a new rule in this branch and updating an existing rule with alerts from main work as expected.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @doakalexi

@doakalexi doakalexi merged commit 48e61e8 into elastic:main Apr 18, 2024
17 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:review backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.15.0
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

8 participants