Onboard Transaction Error Rate rule type with FAAD

x-pack/plugins/observability_solution/apm/server/routes/alerts/register_apm_rule_types.ts

@@ -19,7 +19,10 @@ import {
 import { ObservabilityPluginSetup } from '@kbn/observability-plugin/server';
 import { IRuleDataClient } from '@kbn/rule-registry-plugin/server';
 import { MlPluginSetup } from '@kbn/ml-plugin/server';
-import { legacyExperimentalFieldMap } from '@kbn/alerts-as-data-utils';
+import {
+  legacyExperimentalFieldMap,
+  ObservabilityApmAlert,
+} from '@kbn/alerts-as-data-utils';
 import type { APMIndices } from '@kbn/apm-data-access-plugin/server';
 import {
   AGENT_NAME,
@@ -96,12 +99,13 @@ export const apmRuleTypeAlertFieldMap = {
 };
 
 // Defines which alerts-as-data index alerts will use
-export const ApmRuleTypeAlertDefinition: IRuleTypeAlerts = {
-  context: APM_RULE_TYPE_ALERT_CONTEXT,
-  mappings: { fieldMap: apmRuleTypeAlertFieldMap },
-  useLegacyAlerts: true,
-  shouldWrite: false,
-};
+export const ApmRuleTypeAlertDefinition: IRuleTypeAlerts<ObservabilityApmAlert> =
+  {
+    context: APM_RULE_TYPE_ALERT_CONTEXT,
+    mappings: { fieldMap: apmRuleTypeAlertFieldMap },
+    useLegacyAlerts: true,
+    shouldWrite: true,
+  };
 
 export interface RegisterRuleDependencies {
   alerting: AlertingPluginSetupContract;

x-pack/plugins/observability_solution/apm/server/routes/alerts/rule_types/anomaly/register_anomaly_rule_type.ts

@@ -14,7 +14,6 @@ import {
   RuleTypeState,
   RuleExecutorOptions,
   AlertsClientError,
-  IRuleTypeAlerts,
 } from '@kbn/alerting-plugin/server';
 import { KibanaRequest, DEFAULT_APP_CATEGORIES } from '@kbn/core/server';
 import datemath from '@kbn/datemath';
@@ -381,10 +380,7 @@ export function registerAnomalyRuleType({
 
       return { state: {} };
     },
-    alerts: {
-      ...ApmRuleTypeAlertDefinition,
-      shouldWrite: true,
-    } as IRuleTypeAlerts<AnomalyAlert>,
+    alerts: ApmRuleTypeAlertDefinition,
     getViewInAppRelativeUrl: ({ rule }: GetViewInAppRelativeUrlFnOpts<{}>) =>
       observabilityPaths.ruleDetails(rule.id),
   });

x-pack/plugins/observability_solution/apm/server/routes/alerts/rule_types/error_count/register_error_count_rule_type.ts

@@ -14,7 +14,6 @@ import {
   RuleTypeState,
   RuleExecutorOptions,
   AlertsClientError,
-  IRuleTypeAlerts,
 } from '@kbn/alerting-plugin/server';
 import {
   formatDurationFromTimeUnitChar,
@@ -308,10 +307,7 @@ export function registerErrorCountRuleType({
 
       return { state: {} };
     },
-    alerts: {
-      ...ApmRuleTypeAlertDefinition,
-      shouldWrite: true,
-    } as IRuleTypeAlerts<ErrorCountAlert>,
+    alerts: ApmRuleTypeAlertDefinition,
     getViewInAppRelativeUrl: ({ rule }: GetViewInAppRelativeUrlFnOpts<{}>) =>
       observabilityPaths.ruleDetails(rule.id),
   });

x-pack/plugins/observability_solution/apm/server/routes/alerts/rule_types/transaction_duration/register_transaction_duration_rule_type.ts

@@ -15,7 +15,6 @@ import {
   AlertInstanceState as AlertState,
   RuleTypeState,
   RuleExecutorOptions,
-  IRuleTypeAlerts,
 } from '@kbn/alerting-plugin/server';
 import {
   asDuration,
@@ -358,10 +357,7 @@ export function registerTransactionDurationRuleType({
 
       return { state: {} };
     },
-    alerts: {
-      ...ApmRuleTypeAlertDefinition,
-      shouldWrite: true,
-    } as IRuleTypeAlerts<TransactionDurationAlert>,
+    alerts: ApmRuleTypeAlertDefinition,
     getViewInAppRelativeUrl: ({ rule }: GetViewInAppRelativeUrlFnOpts<{}>) =>
       observabilityPaths.ruleDetails(rule.id),
   });