[Cypress] Hardcode fleet server 8.13.0 version in tests #180879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomsonpl
added
release_note:skip
|
/ci |
tomsonpl
changed the title
tomsonpl
requested review from
MadameSheema,
patrykkopycinski,
oatkiller,
maximpn and
banderror
as code owners
maximpn
approved these changes
Apr 16, 2024
| @@ -12,7 +12,7 @@ import { | |||
| startFleetServer, | |||
| } from '@kbn/security-solution-plugin/scripts/endpoint/common/fleet_server/fleet_server_services'; | |||
| import { Manager } from './resource_manager'; | |||
| import { getLatestAvailableAgentVersion } from './utils'; | |||
| // import { getLatestAvailableAgentVersion } from './utils'; | |||
There was a problem hiding this comment.
nit: It's better to remove code instead of commenting it. Even when you plan to uncomment it in a next PR it may never happen.
There was a problem hiding this comment.
Thank you Maxim, in general I agree, but I really hope that this will get back in place ASAP, we don't want a hardcoded version here forever ;p
But anyway: I hope you don't mind if we keep it this way this time, I want to get this merged asap since it's FF day.
|
Proven to work in a separate PR: #180871 - admin-merging to get main unblocked |
💔 Build FailedFailed CI Steps
Metrics [docs]
HistoryTo update your PR or re-run it, just comment with: cc @tomsonpl |
tomsonpl
added a commit
to tomsonpl/kibana
that referenced
this pull request
Apr 17, 2024
…tic#180879)" This reverts commit 501837a.
tomsonpl
added a commit
to tomsonpl/kibana
that referenced
this pull request
Apr 22, 2024
…tic#180879)" This reverts commit 501837a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've identified all Cypress tests using
fleet-serverin8.14.0version have started to fail recently therefore blocking other PRs from merging.Together with @szwarckonrad we came up with this PR as a quick fix that hardcodes our tests to use FS 8.13.0 in order to unblock other PRs.
@elastic/fleet I believe this should be investigated on your side too as to understand what changed in 8.14.0 that FS is unable to register within ES. I am wondering if this is just our tests not being aligned with new changes, or is it a real bug in production?
cc: @dasansol92
