Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cypress] Hardcode fleet server 8.13.0 version in tests #180879

Merged
merged 3 commits into from
Apr 16, 2024
Merged

[Cypress] Hardcode fleet server 8.13.0 version in tests #180879

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49d6bc1
test 8.13.0 fs
tomsonpl Apr 16, 2024
9c49bee
osquery fs 8.13.0
tomsonpl Apr 16, 2024
270d64a
comments
tomsonpl Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions x-pack/plugins/security_solution/scripts/run_cypress/parallel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,7 @@ ${JSON.stringify(

fleetServer = await startFleetServer({
kbnClient,
version: '8.13.0-SNAPSHOT',
logger: log,
port:
fleetServerPort ?? config.has('servers.fleetserver.port')
Expand Down
5 changes: 3 additions & 2 deletions x-pack/test/osquery_cypress/fleet_server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
startFleetServer,
} from '@kbn/security-solution-plugin/scripts/endpoint/common/fleet_server/fleet_server_services';
import { Manager } from './resource_manager';
import { getLatestAvailableAgentVersion } from './utils';
// import { getLatestAvailableAgentVersion } from './utils';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It's better to remove code instead of commenting it. Even when you plan to uncomment it in a next PR it may never happen.

Copy link
Contributor Author

@tomsonpl tomsonpl Apr 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Maxim, in general I agree, but I really hope that this will get back in place ASAP, we don't want a hardcoded version here forever ;p
But anyway: I hope you don't mind if we keep it this way this time, I want to get this merged asap since it's FF day.


export class FleetManager extends Manager {
private fleetServer: StartedFleetServer | undefined = undefined;
Expand All @@ -26,7 +26,8 @@ export class FleetManager extends Manager {
}

public async setup(): Promise<void> {
const version = await getLatestAvailableAgentVersion(this.kbnClient);
const version = '8.13.0-SNAPSHOT';
// const version = await getLatestAvailableAgentVersion(this.kbnClient);
this.fleetServer = await startFleetServer({
kbnClient: this.kbnClient,
logger: this.log,
Expand Down