[input controls] update dropdown suggestions when filtered #18985

nreese · 2018-05-10T20:34:42Z

PR adds new configuration Dynamic Options. When set to true, the dropdown options list is updated and filtered by the user input.

nreese · 2018-05-10T20:43:59Z

cc @AlonaNadler

elasticmachine · 2018-05-10T21:37:17Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

chrisdavies

LGTM w/ possible tweaks

chrisdavies · 2018-05-11T19:36:58Z

src/core_plugins/input_control_vis/public/components/vis/input_control_vis.js

              controlIndex={index}
              stageFilter={this.props.stageFilter}
+              fetchOptions={async (query) => { return await this.props.refreshControl(index, query); }}
            />


In this case, the caller of fetchOptions is doing an await, so you can make this query => this.props.refreshControl(index, query) since the caller is handling a promise anyway.

Er. Also, I wonder if we can get rid of props.refreshControl altogether, and just do query => control.fetch(query) here, and allow the base Control to intelligently refresh when a query completes? Not sure. I don't know enough about this.

There is no good way to update control in this component since it's state is passed in as props.

chrisdavies · 2018-05-11T19:43:37Z

src/core_plugins/input_control_vis/public/control/list_control_factory.js

    const resp = await searchSource.fetch();
+    if (query && this.lastQuery !== query) {
+      // search results returned out of order - ignore results from old query
+      return;


Seems this could accidentally blank out the results:

fetch is called twice ('a', 'b')

'b' returns first

'a' returns second, and, and fetch returns undefined

The caller of fetch needs to know that if it gets an undefined, it should do nothing (it should keep its current state). Might be better to have this return the correct results if called out of sync (e.g. in the previous example, 'a' would return 'b's results).

The return is not used to set anything. The resp is used to update this.selectOptions later in the function. Calling return early just short circuits so that this.selectOptions is not updated with no longer needed data.

elasticmachine · 2018-05-11T21:11:58Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

stacey-gammon · 2018-05-14T16:10:45Z

Chatted offline with @nreese about some feedback:

Initially I didn't see the use case for having Dynamic options off at all, but was convinced we should leave it in to improve performance on low cardinality fields.
If we do leave it as an option, I think we should default new input controls to having it on.
If we do leave it as an option, I don't see the use case for giving a size parameter when it's off. Why would anyone limit a low cardinality field so that not every option is shown? To me, this would just present as a bug because it's possible some field options will not be shown, and it would create confusion. My thought is that we should only offer the size option when Dynamic options is on. Agree that this PR shouldn't be blocked on that decision though since this is how it acts now, we are no worse off.
Lets bring in @gchaps to go over the terminology, perhaps helpful tooltip text in addition because by itself, I don't think Dynamic options makes it obvious what is going on. We could also reverse the logic and have it something you turn on for low cardinality fields, rather than something you turn off for low cardinality fields.

Some random ideas:

Improve performance for low cardinality fields by pre-fetching all options once
Add dynamic "search-as-you-type" functionality

elasticmachine · 2018-05-14T16:25:56Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

stacey-gammon · 2018-05-14T17:45:10Z

@nreese - going to hold off on further review until you investigate that bug with searching on ip field. Just lmk when ready to go for a second look.

gchaps · 2018-05-15T16:02:50Z

@nreese @stacey-gammon

Here is some text to consider:

Multiselect -> Allow multiple selection

Dynamic Options -> Update options in response to user input
Tooltip: If enabled, add and remove options based on user input. Otherwise, use a fixed set of options.

Size -> Number of options

elasticmachine · 2018-05-16T16:44:41Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

AlonaNadler · 2018-05-17T14:20:29Z

Thanks @nreese just played with that and it looks great!

…ssion when fetching agg results

nreese · 2018-06-20T20:48:14Z

bug with searching on ip field

Turns out that terms aggregation includes property only works for string fields.

{
  "size": 0,
  "aggs": {
    "termsAgg": {
      "terms": {
        "size": 5,
        "order": {
          "_count": "desc"
        },
        "field": "clientip",
        "include": "1.*"
      }
    }
  },
  "query": {
    "bool": {
      "must": [],
      "filter": [],
      "should": [],
      "must_not": []
    }
  }
}

returns

{
  "took": 8,
  "responses": [
    {
      "error": {
        "root_cause": [
          {
            "type": "aggregation_execution_exception",
            "reason": "Aggregation [termsAgg] cannot support regular expression style include/exclude settings as they can only be applied to string fields. Use an array of values for include/exclude clauses"
          }
        ],
        "type": "search_phase_execution_exception",
        "reason": "all shards failed",
        "phase": "query",
        "grouped": true,
        "failed_shards": [
          {
            "shard": 0,
            "index": "logstash-0",
            "node": "IrnksBJLQ6iv4LreZEBhJg",
            "reason": {
              "type": "aggregation_execution_exception",
              "reason": "Aggregation [termsAgg] cannot support regular expression style include/exclude settings as they can only be applied to string fields. Use an array of values for include/exclude clauses"
            }
          }
        ]
      },
      "status": 500
    }
  ]
}

I tried using filters for non-string fields and that did not work either.

GET logstash-*/_search
{
  "size": 0,
  "aggs": {
    "termsAgg": {
      "terms": {
        "size": 100,
        "order": {
          "_count": "desc"
        },
        "field": "clientip"
      }
    }
  },
  "query": {
    "bool": {
      "must": [
        {
          "prefix" : { 
            "clientip" : "1" 
          }
        }
      ],
      "filter": [],
      "should": [],
      "must_not": []
    }
  }
}

just returns

{
  "error": {
    "root_cause": [
      {
        "type": "query_shard_exception",
        "reason": "Can only use prefix queries on keyword and text fields - not on [clientip] which is of type [ip]",
        "index_uuid": "KWhhNlvAQwC9MWfaL6f8sw",
        "index": "logstash-0"
      }
    ],
    "type": "search_phase_execution_exception",
    "reason": "all shards failed",
    "phase": "query",
    "grouped": true,
    "failed_shards": [
      {
        "shard": 0,
        "index": "logstash-0",
        "node": "IrnksBJLQ6iv4LreZEBhJg",
        "reason": {
          "type": "query_shard_exception",
          "reason": "Can only use prefix queries on keyword and text fields - not on [clientip] which is of type [ip]",
          "index_uuid": "KWhhNlvAQwC9MWfaL6f8sw",
          "index": "logstash-0"
        }
      }
    ]
  },
  "status": 400
}

Looks like this option will only be available for String fields.

elasticmachine · 2018-06-20T21:14:29Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-06-25T20:10:30Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-06-25T21:31:44Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

nreese · 2018-06-26T16:26:34Z

blocked on elastic/eui#947

…ted and only display dynamic checkbox when field is string

elasticmachine · 2018-07-06T20:34:37Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-07-06T22:23:25Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

nreese · 2018-07-06T22:27:12Z

@stacey-gammon This is finally ready for review. Now the dynamic options checkbox is only visible for string fields. When checked, size is not allowed to be set.

stacey-gammon · 2018-07-09T17:18:25Z

The dynamic options checkbox is only visible for string fields.

What do you think about making it visible but disabled with a tooltip explanation for non-string fields? Just because I envision answering discuss tickets "why can't I see this option with this field". cc @elastic/kibana-design .

stacey-gammon

small suggestion about the UI and the matching, but otherwise lgtm. Did a code review and pulled code and played around with searching the field values on the visualize app with both dynamic options turned on and off.

stacey-gammon · 2018-07-09T18:53:27Z

src/core_plugins/input_control_vis/public/control/list_control_factory.js

@@ -45,6 +51,11 @@ const termsAgg = (field, size, direction) => {
  } else {
    terms.field = field.name;
  }
+
+  if (query) {
+    terms.include = `${getEscapedQuery(query)}.*`;


What do you think about .*${getEscapedQuery(query)}.* so it searches the middle of the word too, not just a prefix? Esp since thats how it works when you use the size option.

…icOptions

…ng in middle of word

elasticmachine · 2018-07-09T23:29:24Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

… that start with

elasticmachine · 2018-07-10T01:09:13Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…8985) * input controls - re-fetch options list user input * fix jest tests * add functional test case * remove unneeded async and await * use fetchAsRejectablePromise instead of fetch to avoid kill kibana session when fetching agg results * only show options once field is selected * clean up list control editor to only display options when field selected and only display dynamic checkbox when field is string * do not use size when using dynamic options * display disabled toggle when field is not string field, allow searching in middle of word * no tooltip for disabled dyncamic options, just change help text * fix functional test expects since search now includes more than terms that start with

…20604) * input controls - re-fetch options list user input * fix jest tests * add functional test case * remove unneeded async and await * use fetchAsRejectablePromise instead of fetch to avoid kill kibana session when fetching agg results * only show options once field is selected * clean up list control editor to only display options when field selected and only display dynamic checkbox when field is string * do not use size when using dynamic options * display disabled toggle when field is not string field, allow searching in middle of word * no tooltip for disabled dyncamic options, just change help text * fix functional test expects since search now includes more than terms that start with

nreese added release_note:enhancement :Sharing v7.0.0 Feature:Input Control Input controls visualization v6.4.0 labels May 10, 2018

nreese requested review from chrisdavies and stacey-gammon May 10, 2018 22:00

chrisdavies approved these changes May 11, 2018

View reviewed changes

nreese force-pushed the dynamicOptions branch from 34a1994 to 7a02a3a Compare May 14, 2018 14:44

nreese mentioned this pull request May 15, 2018

Input Controls documentation #19005

Closed

nreese added 4 commits May 16, 2018 09:08

input controls - re-fetch options list user input

e47b3f7

fix jest tests

c77a92a

add functional test case

b977eea

remove unneeded async and await

032d042

nreese force-pushed the dynamicOptions branch from 7a02a3a to 032d042 Compare May 16, 2018 15:08

nreese added 2 commits June 20, 2018 13:34

merge with master

7d82dca

use fetchAsRejectablePromise instead of fetch to avoid kill kibana se…

74e39f3

…ssion when fetching agg results

merge with master

dd88475

only show options once field is selected

1c270eb

nreese mentioned this pull request Jun 29, 2018

make timeout and terminate_after configurable #17423

Closed

nreese added 2 commits July 6, 2018 12:21

merge with master

c31d06f

clean up list control editor to only display options when field selec…

753f78e

…ted and only display dynamic checkbox when field is string

do not use size when using dynamic options

136cb26

stacey-gammon approved these changes Jul 9, 2018

View reviewed changes

nreese added 3 commits July 9, 2018 14:55

Merge branch 'master' of https://github.com/elastic/kibana into dynam…

cf80585

…icOptions

display disabled toggle when field is not string field, allow searchi…

7524382

…ng in middle of word

no tooltip for disabled dyncamic options, just change help text

78baa90

fix functional test expects since search now includes more than terms…

aefa360

… that start with

nreese merged commit 00f81dc into elastic:master Jul 10, 2018

nreese mentioned this pull request Jul 10, 2018

[6.x] [input controls] update dropdown suggestions when filtered (#18985) #20604

Merged

timroes mentioned this pull request Jul 31, 2018

Controls visualization should have configurable timeout and terminate_after #17388

Closed

bhavyarm mentioned this pull request Aug 22, 2018

Accessibility 6.4 meta issue #22250

Closed

16 tasks

flash1293 mentioned this pull request Jun 3, 2019

Input controls dropdown - query as-you-type so all available results are shown #14529

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[input controls] update dropdown suggestions when filtered #18985

[input controls] update dropdown suggestions when filtered #18985

nreese commented May 10, 2018 •

edited

Loading

nreese commented May 10, 2018

elasticmachine commented May 10, 2018

chrisdavies left a comment

chrisdavies May 11, 2018

chrisdavies May 11, 2018

nreese May 11, 2018

chrisdavies May 11, 2018

nreese May 11, 2018 •

edited

Loading

elasticmachine commented May 11, 2018

stacey-gammon commented May 14, 2018

elasticmachine commented May 14, 2018

stacey-gammon commented May 14, 2018

gchaps commented May 15, 2018

elasticmachine commented May 16, 2018

AlonaNadler commented May 17, 2018

nreese commented Jun 20, 2018 •

edited

Loading

elasticmachine commented Jun 20, 2018

elasticmachine commented Jun 25, 2018

elasticmachine commented Jun 25, 2018

nreese commented Jun 26, 2018

elasticmachine commented Jul 6, 2018

elasticmachine commented Jul 6, 2018

nreese commented Jul 6, 2018

stacey-gammon commented Jul 9, 2018

stacey-gammon left a comment

stacey-gammon Jul 9, 2018

elasticmachine commented Jul 9, 2018

elasticmachine commented Jul 10, 2018

[input controls] update dropdown suggestions when filtered #18985

[input controls] update dropdown suggestions when filtered #18985

Conversation

nreese commented May 10, 2018 • edited Loading

nreese commented May 10, 2018

elasticmachine commented May 10, 2018

💚 Build Succeeded

chrisdavies left a comment

Choose a reason for hiding this comment

chrisdavies May 11, 2018

Choose a reason for hiding this comment

chrisdavies May 11, 2018

Choose a reason for hiding this comment

nreese May 11, 2018

Choose a reason for hiding this comment

chrisdavies May 11, 2018

Choose a reason for hiding this comment

nreese May 11, 2018 • edited Loading

Choose a reason for hiding this comment

elasticmachine commented May 11, 2018

💚 Build Succeeded

stacey-gammon commented May 14, 2018

elasticmachine commented May 14, 2018

💔 Build Failed

stacey-gammon commented May 14, 2018

gchaps commented May 15, 2018

elasticmachine commented May 16, 2018

💔 Build Failed

AlonaNadler commented May 17, 2018

nreese commented Jun 20, 2018 • edited Loading

elasticmachine commented Jun 20, 2018

💔 Build Failed

elasticmachine commented Jun 25, 2018

💔 Build Failed

elasticmachine commented Jun 25, 2018

💔 Build Failed

nreese commented Jun 26, 2018

elasticmachine commented Jul 6, 2018

💚 Build Succeeded

elasticmachine commented Jul 6, 2018

💚 Build Succeeded

nreese commented Jul 6, 2018

stacey-gammon commented Jul 9, 2018

stacey-gammon left a comment

Choose a reason for hiding this comment

stacey-gammon Jul 9, 2018

Choose a reason for hiding this comment

elasticmachine commented Jul 9, 2018

💔 Build Failed

elasticmachine commented Jul 10, 2018

💚 Build Succeeded

nreese commented May 10, 2018 •

edited

Loading

nreese May 11, 2018 •

edited

Loading

nreese commented Jun 20, 2018 •

edited

Loading