Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics] Added alerts page #190751

Merged
merged 9 commits into from
Aug 20, 2024
Merged

[Synthetics] Added alerts page #190751

merged 9 commits into from
Aug 20, 2024

Conversation

dominiqueclarke
Copy link
Contributor

@dominiqueclarke dominiqueclarke commented Aug 20, 2024 •
edited by shahzad31
Loading

Summary

Synthetics - add alerts page , it shows related alerts for selected monitor and location !!

image

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@dominiqueclarke
Update x-pack/plugins/observability_solution/synthetics/public/apps/s…
a8efed7 
…ynthetics/components/monitor_details/monitor_alerts/monitor_detail_alerts.tsx
@shahzad31 shahzad31 changed the title added alerts page [Synthetics] Added alerts page Aug 20, 2024
@shahzad31 shahzad31 marked this pull request as ready for review August 20, 2024 07:34
@shahzad31 shahzad31 requested a review from a team as a code owner August 20, 2024 07:34
@shahzad31 shahzad31 added the release_note:feature Makes this part of the condensed release notes label Aug 20, 2024
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Aug 20, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

shahzad31
shahzad31 approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

maryam-saeidi
maryam-saeidi reviewed Aug 20, 2024
View reviewed changes
...s/public/apps/synthetics/components/monitor_details/monitor_alerts/monitor_detail_alerts.tsx Outdated
configurationId={AlertConsumers.OBSERVABILITY}
id={MONITOR_ALERTS_TABLE_ID}
data-test-subj="monitorAlertsTable"
featureIds={[AlertConsumers.UPTIME, AlertConsumers.OBSERVABILITY]}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to pass AlertConsumers.OBSERVABILITY featured here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/slo/public/hooks/use_fetch_active_alerts.ts#L58

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably not needed, will remove

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to update here, we had a discussion in Slack and this might be needed for Serverless, needs to be verified.

@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 20, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 63afd08
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-190751-63afd08a5b87

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
synthetics 991 1020 +29

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 924.4KB 934.3KB +9.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
synthetics 34.9KB 37.0KB +2.1KB
Unknown metric groups

async chunk count

id before after diff
synthetics 14 15 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit 398daa1 into elastic:main Aug 20, 2024
26 checks passed
@shahzad31 shahzad31 deleted the feat/synthetics-alerts-page branch August 20, 2024 11:35
@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

@maryam-saeidi maryam-saeidi maryam-saeidi left review comments

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:feature Makes this part of the condensed release notes Team:obs-ux-management Observability Management User Experience Team v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dominiqueclarke @obltmachine @elasticmachine @kibana-ci @shahzad31 @maryam-saeidi @kibanamachine